[GitHub] [airflow] tmbdirec commented on pull request #17156: Create virtualenv via python call

[GitBox <gi...@apache.org>]

tmbdirec commented on pull request #17156:
URL: https://github.com/apache/airflow/pull/17156#issuecomment-884909273


   Call end
   
   รับ Outlook สำหรับ Android<https://aka.ms/AAb9ysg>
   ________________________________
   From: Jakub Semrič ***@***.***>
   Sent: Thursday, July 22, 2021 3:51:28 PM
   To: apache/airflow ***@***.***>
   Cc: Subscribed ***@***.***>
   Subject: [apache/airflow] Create virtualenv via python call (#17156)
   
   
   This PR creates virtualenv with python call instead of subprocess to make it work with MWAA. Currently MWAA would fail on
   
   FileNotFoundError: [Errno 2] No such file or directory: 'virtualenv': 'virtualenv'
   
   
   ________________________________
   
   ^ Add meaningful description above
   
   Read the Pull Request Guidelines<https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines> for more information.
   In case of fundamental code change, Airflow Improvement Proposal (AIP<https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals>) is needed.
   In case of a new dependency, check compliance with the ASF 3rd Party License Policy<https://www.apache.org/legal/resolved.html#category-x>.
   In case of backwards incompatible changes please leave a note in UPDATING.md<https://github.com/apache/airflow/blob/main/UPDATING.md>.
   
   ________________________________
   You can view, comment on, or merge this pull request online at:
   
     https://github.com/apache/airflow/pull/17156
   
   Commit Summary
   
     *   create virtualenv via python call
   
   File Changes
   
     *   M airflow/utils/python_virtualenv.py<https://github.com/apache/airflow/pull/17156/files#diff-af06f7c8b81955780224f1cf28e21b926454fa9c177c4b0ae57d49233a29b418> (5)
   
   Patch Links:
   
     *   https://github.com/apache/airflow/pull/17156.patch
     *   https://github.com/apache/airflow/pull/17156.diff
   
   —
   You are receiving this because you are subscribed to this thread.
   Reply to this email directly, view it on GitHub<https://github.com/apache/airflow/pull/17156>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AU3WDDFA6QD6HBJLZEUBF3LTY7LZBANCNFSM5AZRW66Q>.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org