[jira] [Commented] (ISIS-1609) @Property(editing=ENABLED) not working for some JAXB view model properties.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ISIS-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990661#comment-15990661 ] 

ASF subversion and git services commented on ISIS-1609:
-------------------------------------------------------

Commit bd11d5f2c5eba27d89d5f724b781c010d1fb8436 in isis's branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bd11d5f ]

ISIS-1609: fix for facet factories @Property(editing=ENABLED) for JAXB.


> @Property(editing=ENABLED) not working for some JAXB view model properties.
> ---------------------------------------------------------------------------
>
>                 Key: ISIS-1609
>                 URL: https://issues.apache.org/jira/browse/ISIS-1609
>             Project: Isis
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.14.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: 1.15.0
>
>
> Tracked down the issue to RecreatableObjectFacetForXmlRootElementAnnotation being installed, and then DisabledFacetOn{Property|Collection}DerivedFromRecreatableObject being installed even if the RecreatableObjectFacet sometimes returns null (for JAXB elements, and if implements ViewModelFacet.Cloneable).
> Solution: rather than rely on ViewModelFacet#isCloneable(Object), which works at the object level, instead introduce a new ViewModelFacet#inferImmutable(), which acts at the class level, and from this be able to figure out if the DisabledFacet thus installed has inverted semantics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)