You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/22 16:20:57 UTC

[GitHub] [airflow] ngaranko commented on a change in pull request #14701: HttpHook. Use request factory and respect defaults

ngaranko commented on a change in pull request #14701:
URL: https://github.com/apache/airflow/pull/14701#discussion_r618551768



##########
File path: tests/providers/http/sensors/test_http.py
##########
@@ -201,6 +201,9 @@ def prepare_request(self, request):
             self.response._content += ('/' + request.params['date']).encode('ascii', 'ignore')
         return self.response
 
+    def merge_environment_settings(self, _url, **kwargs):
+        return kwargs
+

Review comment:
       This is test mock for `requests.Session.merge_environment_settings` code, which is called in https://github.com/apache/airflow/pull/14701/files#diff-b644517c333b1a654b85edd76607b296990c14f203b8521091458a46fa228359R184
   
   It is needed to make tests work with `FakeSession` class instead of regular session.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org