You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "Doğacan Güney (JIRA)" <ji...@apache.org> on 2007/05/22 11:23:16 UTC

[jira] Commented: (NUTCH-489) URLFilter-suffix management of the url path when the url contains some query parameters

    [ https://issues.apache.org/jira/browse/NUTCH-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497770 ] 

Doğacan Güney commented on NUTCH-489:
-------------------------------------

This is obviously useful but:

* Your patches both in this issue and in NUTCH-488 have whitespace issues. Nutch uses (or at least, tries to use) 2-space indentation. You seem to use a tab-indentation, so your patches end up removing code only to re-add it with wrong indentation.

* I don't understand why new P option only works after I. What if I want this filter to be case-sensitive and to filter on path?

* (Not related to your patch) It seems even a "-I" line makes SuffixURLFilter ignore case. Is that intended?


> URLFilter-suffix management of the url path when the url contains some query parameters
> ---------------------------------------------------------------------------------------
>
>                 Key: NUTCH-489
>                 URL: https://issues.apache.org/jira/browse/NUTCH-489
>             Project: Nutch
>          Issue Type: Improvement
>    Affects Versions: 0.9.0
>         Environment: Windows, Java 1.5
>            Reporter: Emmanuel Joke
>         Attachments: suffix-urlfilter.txt.patch, SuffixURLFilter.java.patch
>
>
> The current filter compares only on string level. It try to apply the filter to the full URL (path + query parameters).
> So, even if we have define in our filter to exclude all js extension, it won't exclude this URL http://www.toto.com/from.js?id=5.
> I've added a new parameter in the filter which can be use to configure the filter to exclude URL based on the url path.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.