[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4330: fs/littlefs: improve littlefs flash block erase balance performance

[GitBox <gi...@apache.org>]

gustavonihei commented on a change in pull request #4330:
URL: https://github.com/apache/incubator-nuttx/pull/4330#discussion_r687915523



##########
File path: fs/littlefs/lfs_vfs.c
##########
@@ -1019,12 +1019,14 @@ static int littlefs_bind(FAR struct inode *driver, FAR const void *data,
   fs->cfg.prog           = littlefs_write_block;
   fs->cfg.erase          = littlefs_erase_block;
   fs->cfg.sync           = littlefs_sync_block;
-  fs->cfg.read_size      = fs->geo.blocksize;
+  fs->cfg.read_size      = fs->geo.blocksize
+                           * CONFIG_FS_LITTLEFS_BLOCK_FACTOR;

Review comment:
       ```suggestion
     fs->cfg.read_size      = fs->geo.blocksize *
                              CONFIG_FS_LITTLEFS_BLOCK_FACTOR;
   ```
   I think there is no entry on the coding standard for this, but the most usual is to break the line after the operator.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org