You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by liancheng <gi...@git.apache.org> on 2014/10/26 18:40:10 UTC
[GitHub] spark pull request: [SPARK-4091][Core] Don't delete spark local di...
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/2945
[SPARK-4091][Core] Don't delete spark local directories twice
Temporary local directories created by `DiskBlockManager` are asked to be deleted at two places:
1. in `DiskBlockManager.addShutdownHook()`
2. in `DiskBlockManager.stop()`
Both of them are executed as shutdown hooks in parallel, and may cause subtle race conditions that makes the 2nd deletion fail. In most cases, this failure is harmless, but when it happens on Jenkins builds that runs Spark SQL tests, it fails `CliSuite`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liancheng/spark spark-4091
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2945.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2945
----
commit cf6c24038b89042ba387492e6cea9d0335a75125
Author: Cheng Lian <li...@databricks.com>
Date: 2014-10-26T17:33:42Z
Don't delete spark local dirs twice
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4091][Core] Don't delete spark local di...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2945#issuecomment-60527767
[Test build #22247 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22247/consoleFull) for PR 2945 at commit [`cf6c240`](https://github.com/apache/spark/commit/cf6c24038b89042ba387492e6cea9d0335a75125).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4091][Core] Don't delete spark local di...
Posted by liancheng <gi...@git.apache.org>.
Github user liancheng closed the pull request at:
https://github.com/apache/spark/pull/2945
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4091][Core] Don't delete spark local di...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2945#issuecomment-60526139
@liancheng It looks like this is a duplicate of #2826, which adds this one-line change plus a change to listFilesSafely(). Mind taking a look at that PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4091][Core] Don't delete spark local di...
Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2945#issuecomment-60542234
Thanks @JoshRosen, closing this. #2826 should have fixed the `CliSuite` issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4091][Core] Don't delete spark local di...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2945#issuecomment-60525266
[Test build #22247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22247/consoleFull) for PR 2945 at commit [`cf6c240`](https://github.com/apache/spark/commit/cf6c24038b89042ba387492e6cea9d0335a75125).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4091][Core] Don't delete spark local di...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2945#issuecomment-60527770
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22247/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org