You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Ted Yu <te...@yahoo.com> on 2010/10/01 00:05:13 UTC
Re: Review Request: hbase-3019 Make bulk assignment on cluster startup run
faster
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/926/#review1372
-----------------------------------------------------------
trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
<http://review.cloudera.org/r/926/#comment4541>
The handling seems to be different from that on line 584.
- Ted
On 2010-09-30 12:55:33, stack wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/926/
> -----------------------------------------------------------
>
> (Updated 2010-09-30 12:55:33)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> hbase-3019 Make bulk assignment on cluster startup run faster
>
> M src/test/java/org/apache/hadoop/hbase/master/TestLogsCleaner.java
> Disable test rather than comment out @Test. junit complains no
> test if do latter.
> M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> M src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
> openRegions: Added
> M src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
> sendOpenRegions: Added
> M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
> Add bulk assign method Add ExecutorService to run bulk assignements.
> M src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
> Enhance logging.
>
>
> This addresses bug hbase-3019.
> http://issues.apache.org/jira/browse/hbase-3019
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1003192
> trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1003192
> trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1003192
> trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java 1003192
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1003192
> trunk/src/test/java/org/apache/hadoop/hbase/master/TestLogsCleaner.java 1003192
>
> Diff: http://review.cloudera.org/r/926/diff
>
>
> Testing
> -------
>
> I've been running patch up on testing cluster... starting and stopping then confirming all regions on line by running rowcounter.
>
>
> Thanks,
>
> stack
>
>
Re: Review Request: hbase-3019 Make bulk assignment on cluster startup run
faster
Posted by st...@duboce.net.
> On 2010-09-30 15:05:13, Ted Yu wrote:
> > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java, line 644
> > <http://review.cloudera.org/r/926/diff/1/?file=13151#file13151line644>
> >
> > The handling seems to be different from that on line 584.
Thanks for the review Ted. Yeah, its different. Thats what the '// TODO: Should we just abort in this case? Then we'll notice these' question was about. I'll make them same on commit. In both cases we'll abort the server so we notice these illegal state changes the sooner.
- stack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/926/#review1372
-----------------------------------------------------------
On 2010-09-30 12:55:33, stack wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/926/
> -----------------------------------------------------------
>
> (Updated 2010-09-30 12:55:33)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> hbase-3019 Make bulk assignment on cluster startup run faster
>
> M src/test/java/org/apache/hadoop/hbase/master/TestLogsCleaner.java
> Disable test rather than comment out @Test. junit complains no
> test if do latter.
> M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> M src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
> openRegions: Added
> M src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
> sendOpenRegions: Added
> M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
> Add bulk assign method Add ExecutorService to run bulk assignements.
> M src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
> Enhance logging.
>
>
> This addresses bug hbase-3019.
> http://issues.apache.org/jira/browse/hbase-3019
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1003192
> trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1003192
> trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1003192
> trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java 1003192
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1003192
> trunk/src/test/java/org/apache/hadoop/hbase/master/TestLogsCleaner.java 1003192
>
> Diff: http://review.cloudera.org/r/926/diff
>
>
> Testing
> -------
>
> I've been running patch up on testing cluster... starting and stopping then confirming all regions on line by running rowcounter.
>
>
> Thanks,
>
> stack
>
>