You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/23 01:40:41 UTC
[jira] [Commented] (BEAM-1780) BigtableReader.splitIntoFraction
should more carefully guard input
[ https://issues.apache.org/jira/browse/BEAM-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937532#comment-15937532 ]
ASF GitHub Bot commented on BEAM-1780:
--------------------------------------
GitHub user dhalperi opened a pull request:
https://github.com/apache/beam/pull/2298
[BEAM-1780] BigtableIO: better handling of bad split requests
The contract for `splitIntoFraction` is that it should only throw if the
reader is in an unknown, bad state. The proper way to reject invalid or
unsatisfiable split requests is to return null.
However, `BigtableIO.Read` will currently throw for simply invalid input
it should reject. This can lead to less effective dynamic work
rebalancing and even stuck jobs.
Related to, but probably not a complete solution for, BEAM-1751.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhalperi/beam bigtable-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2298
----
commit 3172c0ace419355aa050073194337ac0f3b27802
Author: Dan Halperin <dh...@google.com>
Date: 2017-03-22T17:21:33Z
[BEAM-1780] BigtableIO: better handling of bad split requests
The contract for `splitIntoFraction` is that it should only throw if the
reader is in an unknown, bad state. The proper way to reject invalid or
unsatisfiable split requests is to return null.
However, `BigtableIO.Read` will currently throw for simply invalid input
it should reject. This can lead to less effective dynamic work
rebalancing and even stuck jobs.
Related to, but probably not a complete solution for, BEAM-1751.
----
> BigtableReader.splitIntoFraction should more carefully guard input
> ------------------------------------------------------------------
>
> Key: BEAM-1780
> URL: https://issues.apache.org/jira/browse/BEAM-1780
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-gcp
> Reporter: Daniel Halperin
> Assignee: Daniel Halperin
> Fix For: First stable release
>
>
> The contract for {{splitIntoFraction}} is that it should only throw if the reader is in an unknown, bad state. The proper way to reject invalid or unsatisfiable split requests is to return {{null}}.
> However, {{BigtableIO.Read}} will currently throw for simply invalid input it should reject. This can lead to less effective dynamic work rebalancing and even stuck jobs.
> Related to, but probably not a complete solution for, [BEAM-1751].
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)