[GitHub] [spark] shardulm94 commented on pull request #31741: [SPARK-34624][CORE] Exclude non-jar dependencies of ivy/maven packages

[GitBox <gi...@apache.org>]

shardulm94 commented on pull request #31741:
URL: https://github.com/apache/spark/pull/31741#issuecomment-791021507


   @dongjoon-hyun for me, the test case does fail without the patch, both in IntelliJ and via mvn CLI.
   `build/mvn test -Dtest=none -Dsuites="org.apache.spark.deploy.SparkSubmitUtilsSuite SPARK-34624" -pl core`
   ```
   Run starting. Expected test count is: 1
   SparkSubmitUtilsSuite:
   :: loading settings :: url = jar:file:/Users/shardul/.m2/repository/org/apache/ivy/ivy/2.4.0/ivy-2.4.0.jar!/org/apache/ivy/core/settings/ivysettings.xml
   - SPARK-34624: should ignore non-jar dependencies *** FAILED ***
     jarPath.exists(((x$19: String) => x$19.indexOf("mydep").>=(0))) was true should not find pom dependency (SparkSubmitUtilsSuite.scala:310)
   Run completed in 2 seconds, 831 milliseconds.
   Total number of tests run: 1
   Suites: completed 1, aborted 0
   Tests: succeeded 0, failed 1, canceled 0, ignored 0, pending 0
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org