You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/01/30 19:14:05 UTC
[kudu-CR] [build] Improve mini cluster artifact name
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12312
Change subject: [build] Improve mini cluster artifact name
......................................................................
[build] Improve mini cluster artifact name
Adjust the name of the artifact/jar to include the OS and
architecture that matches the expected Maven format
for compatibility with the os-maven-plugin.
As an example, this artifact name matches the protoc
artifact name structure:
http://central.maven.org/maven2/com/google/protobuf/protoc/3.6.1/
Change-Id: I75007d3623aa3c3d06dea083d5d25f241ca1c73c
---
M build-support/build_mini_cluster_binaries.sh
M build-support/relocate_binaries_for_mini_cluster.py
2 files changed, 10 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/12312/1
--
To view, visit http://gerrit.cloudera.org:8080/12312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75007d3623aa3c3d06dea083d5d25f241ca1c73c
Gerrit-Change-Number: 12312
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [build] Improve mini cluster artifact name
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12312
to look at the new patch set (#2).
Change subject: [build] Improve mini cluster artifact name
......................................................................
[build] Improve mini cluster artifact name
Adjust the name of the artifact/jar to include the OS and
architecture that matches the expected Maven format
for compatibility with the os-maven-plugin.
As an example, this artifact name matches the protoc
artifact name structure:
http://central.maven.org/maven2/com/google/protobuf/protoc/3.6.1/
Change-Id: I75007d3623aa3c3d06dea083d5d25f241ca1c73c
---
M build-support/build_mini_cluster_binaries.sh
M build-support/relocate_binaries_for_mini_cluster.py
2 files changed, 10 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/12312/2
--
To view, visit http://gerrit.cloudera.org:8080/12312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75007d3623aa3c3d06dea083d5d25f241ca1c73c
Gerrit-Change-Number: 12312
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Improve mini cluster artifact name
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12312 )
Change subject: [build] Improve mini cluster artifact name
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75007d3623aa3c3d06dea083d5d25f241ca1c73c
Gerrit-Change-Number: 12312
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Jan 2019 19:28:46 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Improve mini cluster artifact name
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12312 )
Change subject: [build] Improve mini cluster artifact name
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12312/1/build-support/relocate_binaries_for_mini_cluster.py
File build-support/relocate_binaries_for_mini_cluster.py:
http://gerrit.cloudera.org:8080/#/c/12312/1/build-support/relocate_binaries_for_mini_cluster.py@191
PS1, Line 191: os_str="linux"
> Nit: separate with spaces. Below too.
Done
--
To view, visit http://gerrit.cloudera.org:8080/12312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75007d3623aa3c3d06dea083d5d25f241ca1c73c
Gerrit-Change-Number: 12312
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Jan 2019 19:25:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Improve mini cluster artifact name
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12312 )
Change subject: [build] Improve mini cluster artifact name
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12312/1/build-support/relocate_binaries_for_mini_cluster.py
File build-support/relocate_binaries_for_mini_cluster.py:
http://gerrit.cloudera.org:8080/#/c/12312/1/build-support/relocate_binaries_for_mini_cluster.py@191
PS1, Line 191: os_str="linux"
Nit: separate with spaces. Below too.
--
To view, visit http://gerrit.cloudera.org:8080/12312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75007d3623aa3c3d06dea083d5d25f241ca1c73c
Gerrit-Change-Number: 12312
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Jan 2019 19:20:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Improve mini cluster artifact name
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12312 )
Change subject: [build] Improve mini cluster artifact name
......................................................................
[build] Improve mini cluster artifact name
Adjust the name of the artifact/jar to include the OS and
architecture that matches the expected Maven format
for compatibility with the os-maven-plugin.
As an example, this artifact name matches the protoc
artifact name structure:
http://central.maven.org/maven2/com/google/protobuf/protoc/3.6.1/
Change-Id: I75007d3623aa3c3d06dea083d5d25f241ca1c73c
Reviewed-on: http://gerrit.cloudera.org:8080/12312
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M build-support/build_mini_cluster_binaries.sh
M build-support/relocate_binaries_for_mini_cluster.py
2 files changed, 10 insertions(+), 3 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I75007d3623aa3c3d06dea083d5d25f241ca1c73c
Gerrit-Change-Number: 12312
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)