[incubator-superset] 16/43: fix invalid name

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch feature--embeddable-charts-pilot
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit 16acd8f0dc6d1ee0678a38eb742fb05d4966c64b
Author: Conglei Shi <co...@airbnb.com>
AuthorDate: Thu Nov 15 00:26:45 2018 -0800

    fix invalid name
---
 superset/common/query_context.py | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/superset/common/query_context.py b/superset/common/query_context.py
index a9a902a..82249a6 100644
--- a/superset/common/query_context.py
+++ b/superset/common/query_context.py
@@ -1,4 +1,4 @@
-# pylint: disable=R
+# pylint: disable=C,R,W
 from datetime import datetime, timedelta
 import logging
 import pickle as pkl
@@ -95,16 +95,16 @@ class QueryContext:
             'df': df,
         }
 
-    def df_metrics_to_num(self, data_frame, query_object):
+    def df_metrics_to_num(self, df, query_object):
         """Converting metrics to numeric when pandas.read_sql cannot"""
         metrics = [metric.label for metric in query_object.metrics]
-        for col, dtype in data_frame.dtypes.items():
+        for col, dtype in df.dtypes.items():
             if dtype.type == np.object_ and col in metrics:
-                data_frame[col] = pd.to_numeric(data_frame[col], errors='coerce')
+                df[col] = pd.to_numeric(df[col], errors='coerce')
 
-    def handle_nulls(self, data_frame):
-        fillna = self.get_fillna_for_columns(data_frame.columns)
-        return data_frame.fillna(fillna)
+    def handle_nulls(self, df):
+        fillna = self.get_fillna_for_columns(df.columns)
+        return df.fillna(fillna)
 
     def get_fillna_for_col(self, col):
         """Returns the value to use as filler for a specific Column.type"""
@@ -124,8 +124,8 @@ class QueryContext:
         }
         return fillna
 
-    def get_data(self, data_frame):
-        return data_frame.to_dict(orient='records')
+    def get_data(self, df):
+        return df.to_dict(orient='records')
 
     def get_single_payload(self, query_obj):
         """Returns a payload of metadata and data"""