You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/07/06 05:15:35 UTC
[GitHub] [dubbo-go] CoolIceV opened a new issue, #1954: Unnecessary time formatting in NewHillClimbingUpdater of adaptive service
CoolIceV opened a new issue, #1954:
URL: https://github.com/apache/dubbo-go/issues/1954
**What happened:**
When I tested the adaptive service, I found that the cpu load on the adaptive service was much higher, I used pprof to analyse it and found that a lot of CPU time was spent on the time formatting in the `NewHillClimbingUpdater` function.
I found that even though `adaptive-service-verbose` is set to false, the code still converts the time to a string and passes it to `VerboseDebugf`, which is completely unnecessary
https://github.com/apache/dubbo-go/blob/b7e348319f82444e18ecda284e20656d7ed3b861/filter/adaptivesvc/limiter/hill_climbing.go#L125-L135
**What you expected to happen:**
When `adaptive-service-verbose` is set to false, formatting time is no longer executed.
**How to reproduce it (as minimally and precisely as possible):**
The following is set in conf:
```
adaptive-service: true
adaptive-service-verbose: false
```
**Anything else we need to know?:**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] CoolIceV closed issue #1954: Unnecessary time formatting in NewHillClimbingUpdater of adaptive service
Posted by GitBox <gi...@apache.org>.
CoolIceV closed issue #1954: Unnecessary time formatting in NewHillClimbingUpdater of adaptive service
URL: https://github.com/apache/dubbo-go/issues/1954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org