[GitHub] [druid] gianm commented on pull request #14046: MSQ: Use the same result coercion routines as the regular SQL endpoint.

["gianm (via GitHub)" <gi...@apache.org>]

gianm commented on PR #14046:
URL: https://github.com/apache/druid/pull/14046#issuecomment-1507804941

   > I tested out the changes by applying the diff, and checking which all tests can pass now. Can you enable the tests in the PR itself by applying the following diff?
   > 
   > [enable-tests.patch](https://github.com/apache/druid/files/11186703/enable-tests.patch)
   
   @LakshSingla Very cool note. For some reason, the patch didn't apply, so I took a different approach: I ran the tests ignoring the `msqCompatible` flag and marked all ones that passed as MSQ-compatible.
   
   Now that most of the tests are MSQ-compatible, I also flipped the way we mark them, so by default all tests are run with MSQ, and the _incompatible_ tests are marked with `notMsqCompatible()`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org