[GitHub] [iceberg] rdblue commented on a diff in pull request #7081: Core: Allow injecting resources in REST and JDBC catalogs

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #7081:
URL: https://github.com/apache/iceberg/pull/7081#discussion_r1133140243


##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -127,6 +136,19 @@ public void setFileIOBuilder(Function<Map<String, String>, FileIO> newIOBuilder)
     this.ioBuilder = newIOBuilder;
   }
 
+  public void setClientPoolBuilder(
+      Function<Map<String, String>, JdbcClientPool> newClientPoolBuilder) {
+    Preconditions.checkState(
+        null == connections, "Cannot set client pool builder after calling initialize");
+    this.clientPoolBuilder = newClientPoolBuilder;
+  }
+
+  public void setInitializeCatalogTables(boolean initializeCatalogTables) {

Review Comment:
   Why is this needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org