You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2017/04/18 20:29:57 UTC

[3/6] tinkerpop git commit: Merge branch 'TINKERPOP-1044' into TINKERPOP-1044-master

Merge branch 'TINKERPOP-1044' into TINKERPOP-1044-master

Conflicts:
	gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java
	gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerHttpIntegrateTest.java


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/92eceb4e
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/92eceb4e
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/92eceb4e

Branch: refs/heads/master
Commit: 92eceb4e620409be2c9ee810cc4132b7ae2dafc7
Parents: bc4cf2b c33069c
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Fri Apr 7 08:22:31 2017 -0400
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Fri Apr 7 08:22:31 2017 -0400

----------------------------------------------------------------------
 CHANGELOG.asciidoc                              |  2 ++
 .../upgrade/release-3.2.x-incubating.asciidoc   | 35 ++++++++++++++++++
 .../tinkerpop/gremlin/driver/Handler.java       | 11 ++++--
 .../apache/tinkerpop/gremlin/driver/Tokens.java |  3 ++
 .../driver/exception/ResponseException.java     | 27 ++++++++++++++
 .../gremlin/driver/message/ResponseMessage.java | 19 ++++++++++
 .../gremlin/driver/ResultQueueTest.java         |  2 --
 .../handler/GremlinResponseFrameEncoder.java    |  6 ++--
 .../handler/HttpGremlinEndpointHandler.java     |  9 +++--
 .../gremlin/server/handler/IteratorHandler.java |  5 ++-
 .../handler/NioGremlinResponseEncoder.java      |  5 +--
 .../server/handler/OpExecutorHandler.java       |  1 +
 .../server/handler/OpSelectorHandler.java       |  4 ++-
 .../handler/WsGremlinResponseEncoder.java       |  5 +--
 .../server/op/AbstractEvalOpProcessor.java      | 27 ++++++++++----
 .../gremlin/server/op/AbstractOpProcessor.java  |  5 +--
 .../op/traversal/TraversalOpProcessor.java      | 35 +++++++++++++-----
 .../gremlin/server/util/ExceptionHelper.java    | 38 ++++++++++++++++++++
 .../server/GremlinDriverIntegrateTest.java      |  5 +++
 .../server/GremlinServerHttpIntegrateTest.java  |  8 +++++
 20 files changed, 220 insertions(+), 32 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/92eceb4e/CHANGELOG.asciidoc
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/92eceb4e/docs/src/upgrade/release-3.2.x-incubating.asciidoc
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/92eceb4e/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Handler.java
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/92eceb4e/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/HttpGremlinEndpointHandler.java
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/92eceb4e/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java
----------------------------------------------------------------------
diff --cc gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java
index 13e5968,ffbda08..33e8108
--- a/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java
+++ b/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java
@@@ -290,8 -288,17 +295,10 @@@ public abstract class AbstractEvalOpPro
                  } else if (t instanceof TimedInterruptTimeoutException) {
                      // occurs when the TimedInterruptCustomizerProvider is in play
                      final String errorMessage = String.format("A timeout occurred within the script during evaluation of [%s] - consider increasing the limit given to TimedInterruptCustomizerProvider", msg);
 -                    logger.warn(errorMessage);
 -                    ctx.writeAndFlush(ResponseMessage.build(msg).code(ResponseStatusCode.SERVER_ERROR_TIMEOUT)
 -                            .statusMessage("Timeout during script evaluation triggered by TimedInterruptCustomizerProvider")
 -                            .statusAttributeException(t).create());
 -                } else if (t instanceof org.apache.tinkerpop.gremlin.groovy.jsr223.TimedInterruptTimeoutException) {
 -                    // occurs when the TimedInterruptCustomizerProvider is in play
 -                    final String errorMessage = String.format("A timeout occurred within the script during evaluation of [%s] - consider increasing the limit given to TimedInterruptCustomizerProvider", msg);
                      logger.warn(errorMessage);
-                     ctx.writeAndFlush(ResponseMessage.build(msg).code(ResponseStatusCode.SERVER_ERROR_TIMEOUT).statusMessage("Timeout during script evaluation triggered by TimedInterruptCustomizerProvider").create());
+                     ctx.writeAndFlush(ResponseMessage.build(msg).code(ResponseStatusCode.SERVER_ERROR_TIMEOUT)
+                             .statusMessage("Timeout during script evaluation triggered by TimedInterruptCustomizerProvider")
+                             .statusAttributeException(t).create());
                  } else if (t instanceof TimeoutException) {
                      final String errorMessage = String.format("Script evaluation exceeded the configured threshold for request [%s] - %s", msg, t.getMessage());
                      logger.warn(errorMessage, t);

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/92eceb4e/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/traversal/TraversalOpProcessor.java
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/92eceb4e/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/92eceb4e/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerHttpIntegrateTest.java
----------------------------------------------------------------------
diff --cc gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerHttpIntegrateTest.java
index 9cea2ce,b1cbd7f..0d4f49c
--- a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerHttpIntegrateTest.java
+++ b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerHttpIntegrateTest.java
@@@ -18,10 -18,8 +18,11 @@@
   */
  package org.apache.tinkerpop.gremlin.server;
  
 +import org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerV1d0;
+ import org.apache.tinkerpop.gremlin.driver.Tokens;
  import org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerV2d0;
 +import org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerV3d0;
 +import org.apache.tinkerpop.gremlin.jsr223.ScriptFileGremlinPlugin;
  import org.apache.tinkerpop.gremlin.server.auth.SimpleAuthenticator;
  import org.apache.tinkerpop.gremlin.server.channel.HttpChannelizer;
  import org.apache.http.Consts;