You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Edgar Poce (JIRA)" <ji...@apache.org> on 2005/10/05 21:14:47 UTC
[jira] Created: (JCR-243) expose shutdown method in o.a.j.jndi.BindableRepository
expose shutdown method in o.a.j.jndi.BindableRepository
-------------------------------------------------------
Key: JCR-243
URL: http://issues.apache.org/jira/browse/JCR-243
Project: Jackrabbit
Type: Improvement
Reporter: Edgar Poce
Priority: Minor
see http://thread.gmane.org/gmane.comp.apache.jackrabbit.devel/3680
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-243) expose shutdown method in o.a.j.jndi.BindableRepository
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-243?page=comments#action_12331482 ]
Stefan Guggisberg commented on JCR-243:
---------------------------------------
BindableRepository is a jndi support specific class. rather than allowing every jndi client to
shutdown the repository instance retrieved from the jndi registry i think a cleaner approach
would be to explicitly (through a boolean argument) or implicitly shutdown the repository
instance in RegistryHelper.unregisterRepository. i guess the code that explicitly
instantiated a RepositoyInstance is also responsible for shutting it down.
i suggest to remove to public modifiers of BindableRepository and shutdown and add
a boolean 'shutdown' to RegistryHelper.unregisterRepository.
> expose shutdown method in o.a.j.jndi.BindableRepository
> -------------------------------------------------------
>
> Key: JCR-243
> URL: http://issues.apache.org/jira/browse/JCR-243
> Project: Jackrabbit
> Type: Improvement
> Reporter: Edgar Poce
> Assignee: Edgar Poce
> Priority: Minor
> Attachments: 05-10-05-bindablerepository.patch
>
> see http://thread.gmane.org/gmane.comp.apache.jackrabbit.devel/3680
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-243) expose shutdown method in o.a.j.jndi.BindableRepository
Posted by "Edgar Poce (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-243?page=comments#action_12331545 ]
Edgar Poce commented on JCR-243:
--------------------------------
I agree, it has sense that if the webapp doesn't start it it shouldn't shut it down. I didn't add an argument, please add it if you prefer the explicit shutdown .
thanks for your suggestion.
fixed in rev. 306970.
> expose shutdown method in o.a.j.jndi.BindableRepository
> -------------------------------------------------------
>
> Key: JCR-243
> URL: http://issues.apache.org/jira/browse/JCR-243
> Project: Jackrabbit
> Type: Improvement
> Reporter: Edgar Poce
> Assignee: Edgar Poce
> Priority: Minor
> Attachments: 05-10-05-bindablerepository.patch
>
> see http://thread.gmane.org/gmane.comp.apache.jackrabbit.devel/3680
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JCR-243) expose shutdown method in o.a.j.jndi.BindableRepository
Posted by "Edgar Poce (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-243?page=all ]
Edgar Poce updated JCR-243:
---------------------------
Attachment: 05-10-05-bindablerepository.patch
The proposed patch that should fix the problem detailed in a recent conversation about shutting down jackrabbit.
> expose shutdown method in o.a.j.jndi.BindableRepository
> -------------------------------------------------------
>
> Key: JCR-243
> URL: http://issues.apache.org/jira/browse/JCR-243
> Project: Jackrabbit
> Type: Improvement
> Reporter: Edgar Poce
> Priority: Minor
> Attachments: 05-10-05-bindablerepository.patch
>
> see http://thread.gmane.org/gmane.comp.apache.jackrabbit.devel/3680
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (JCR-243) expose shutdown method in o.a.j.jndi.BindableRepository
Posted by "Edgar Poce (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-243?page=all ]
Edgar Poce resolved JCR-243:
----------------------------
Resolution: Fixed
Assign To: Edgar Poce
> expose shutdown method in o.a.j.jndi.BindableRepository
> -------------------------------------------------------
>
> Key: JCR-243
> URL: http://issues.apache.org/jira/browse/JCR-243
> Project: Jackrabbit
> Type: Improvement
> Reporter: Edgar Poce
> Assignee: Edgar Poce
> Priority: Minor
> Attachments: 05-10-05-bindablerepository.patch
>
> see http://thread.gmane.org/gmane.comp.apache.jackrabbit.devel/3680
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira