[GitHub] [spark] aokolnychyi commented on a change in pull request #29089: [SQL][SPARK-32276] Remove redundant sorts before repartition nodes

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #29089:
URL: https://github.com/apache/spark/pull/29089#discussion_r453796416



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -981,6 +982,10 @@ object EliminateSorts extends Rule[LogicalPlan] {
       j.copy(left = recursiveRemoveSort(originLeft), right = recursiveRemoveSort(originRight))
     case g @ Aggregate(_, aggs, originChild) if isOrderIrrelevantAggs(aggs) =>
       g.copy(child = recursiveRemoveSort(originChild))
+    case r: RepartitionByExpression =>

Review comment:
       These two branches can be replaces with one:
   
   ```
   case r: RepartitionOperation =>
     r.withNewChildren(r.children.map(recursiveRemoveSort))
   ```
   
   It will mean all repartition nodes we add in the future will be also taken into account. It seems safe but I want to hear what everybody thinks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org