You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Jiri Kuhn (JIRA)" <ji...@apache.org> on 2009/01/07 16:26:44 UTC
[jira] Created: (FTPSERVER-259) Connection statistics not updated
Connection statistics not updated
---------------------------------
Key: FTPSERVER-259
URL: https://issues.apache.org/jira/browse/FTPSERVER-259
Project: FtpServer
Issue Type: Bug
Components: Core
Affects Versions: 1.0.0-M4
Reporter: Jiri Kuhn
Methods
org.apache.ftpserver.impl.ServerFtpStatistics#setOpenConnection(FtpIoSession)
org.apache.ftpserver.impl.ServerFtpStatistics#setCloseConnection(FtpIoSession)
are never called from production code.
Command SITE_STAT shows only zeros for connection statistics.
Really, really side note: I have looked at DefaultFtpStatistics class. The counters are AtomicIntegers. As all counters are modified inside synchronized methods, I don't think there is any need for the counters to be AtomicInteger at all. Just int should be enough.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FTPSERVER-259) Connection statistics not updated
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niklas Gustavsson closed FTPSERVER-259.
---------------------------------------
Resolution: Fixed
Fix Version/s: 1.0.0-RC1
Assignee: Niklas Gustavsson
Man, you're obsessive with the STAT commands. Love it :-) Fixed in rev 733158 (also discovered and fixed FTPSERVER-261)
> Connection statistics not updated
> ---------------------------------
>
> Key: FTPSERVER-259
> URL: https://issues.apache.org/jira/browse/FTPSERVER-259
> Project: FtpServer
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0-M4
> Reporter: Jiri Kuhn
> Assignee: Niklas Gustavsson
> Fix For: 1.0.0-RC1
>
>
> Methods
> org.apache.ftpserver.impl.ServerFtpStatistics#setOpenConnection(FtpIoSession)
> org.apache.ftpserver.impl.ServerFtpStatistics#setCloseConnection(FtpIoSession)
> are never called from production code.
> Command SITE_STAT shows only zeros for connection statistics.
> Really, really side note: I have looked at DefaultFtpStatistics class. The counters are AtomicIntegers. As all counters are modified inside synchronized methods, I don't think there is any need for the counters to be AtomicInteger at all. Just int should be enough.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.