You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bhaisaab <gi...@git.apache.org> on 2016/04/08 23:45:04 UTC
[GitHub] cloudstack pull request: travis: increase build verbosity
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1481
travis: increase build verbosity
Outputs for modules that fail or succeed with unit tests results.
Based on the issue raised in https://github.com/apache/cloudstack/pull/1466 this PR aims at increasing Travis build output so we can know which unit test fail.
/cc @swill @nvazquez -- let me know if we just allow outputting everything will help? I had restricted the output as including all of them would disallow viewing the tabular final integration/marvin tests at the end (only possible by viewing raw output of each travis job).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack travis-verbosefix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1481.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1481
----
commit 41e3b61245c995c04d93475c91f014a87a989b3b
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-04-08T21:41:39Z
travis: increase build verbosity
Outputs for modules that fail or succeed with unit tests results
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: travis: increase build verbosity
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207630967
on a second thought I'll probably ask this on dev@
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: travis: increase build verbosity
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207631157
I will have to think about that a bit. I think it would be valuable, but I
have to get my head around if there are implications in doing that. Are
there any implications that you can think of? Also, does this add value?
Does it enable us to do more complete testing? Sorry if I am being naive,
but I like to go into this sort of stuff with measured expectations.
On Fri, Apr 8, 2016 at 6:19 PM, रोहित यादव <no...@github.com> wrote:
> @swill <https://github.com/swill> sure :) one more thing I want to
> discuss, should we enable -Dnoredist for Travis builds? I maintain this
> noredist repo which we can use to git clone as the time of running these
> tests and install deps (without including them in our main repo)
> https://github.com/bhaisaab/cloudstack-nonoss
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/1481#issuecomment-207629434>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: travis: increase build verbosity
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207625965
@swill I would say let's wait for travis to go green on this and then merge. Then in future if anything break, we can have a look at the logs to see which unit test or maven module failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: travis: increase build verbosity
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207625716
@bhaisaab thanks for doing this. I suspect the travis run will fail so I will have to break my own rule and force merge. :) I will wait for it to finish regardless and I will get this in so we can better understand what is going on. Thanks again for the quick response to this, this is very helpful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: travis: increase build verbosity
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207628400
Yes, that is what I plan to do. I just saw a different squash commit complete successfully, so it seems that travis is not 'always' failing, even though it has failed with that same message on more than one PR. One of the ones that failed was only pushing a comment in order to test if travis was broken and it still failed, so that means that travis is periodically failing against master right now. That concerns me, so hopefully this goes green. Fingers crossed. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: travis: increase build verbosity
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207629434
@swill sure :) one more thing I want to discuss, should we enable -Dnoredist for Travis builds? I maintain this noredist repo which we can use to git clone as the time of running these tests and install deps (without including them in our main repo) https://github.com/bhaisaab/cloudstack-nonoss
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: travis: increase build verbosity
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207631254
Ya, probably a good discussion to take to dev@.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: travis: increase build verbosity
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1481
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---