You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/04/07 02:26:16 UTC
[GitHub] merlimat opened a new pull request #1523: Use signSafeMod in RoundRobinPartitionMessageRouter
merlimat opened a new pull request #1523: Use signSafeMod in RoundRobinPartitionMessageRouter
URL: https://github.com/apache/incubator-pulsar/pull/1523
### Motivation
I have seen this errors in master with the round-robin message router (used with `perf-producer`) :
```
00:11:08.789 [pulsar-perf-producer-exec-1-1] ERROR org.apache.pulsar.testclient.PerformanceProducer - Got error
java.lang.IllegalArgumentException: Illegal partition index chosen by the message routing policy
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:122) ~[com.google.guava-guava-20.0.jar:?]
at org.apache.pulsar.client.impl.PartitionedProducerImpl.sendAsync(PartitionedProducerImpl.java:170) ~[org.apache.pulsar-pulsar-client-original-2.0.0-incubating-SNAPSHOT.jar:2.0.0-incubating-SNAPSHOT]
at org.apache.pulsar.client.impl.ProducerBase.sendAsync(ProducerBase.java:54) ~[org.apache.pulsar-pulsar-client-original-2.0.0-incubating-SNAPSHOT.jar:2.0.0-incubating-SNAPSHOT]
at org.apache.pulsar.testclient.PerformanceProducer.lambda$0(PerformanceProducer.java:347) ~[org.apache.pulsar-pulsar-testclient-2.0.0-incubating-SNAPSHOT.jar:2.0.0-incubating-SNAPSHOT]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_161]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_161]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_161]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_161]
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [io.netty-netty-all-4.1.21.Final.jar:4.1.21.Final]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_161]
```
Fixed by consistently using `signSafeMod()` function. Imported from BK code since client doesn't depend on BK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services