You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2011/06/28 06:04:17 UTC

[jira] [Commented] (HBASE-3534) Action should not store or serialize regionName

    [ https://issues.apache.org/jira/browse/HBASE-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056277#comment-13056277 ] 

stack commented on HBASE-3534:
------------------------------

@Ted Almost.  I think you have to leave the old constructor, the one that took a region name; it is part of our public API.  Just add new constructor that takes two args and have our code use it.  Have old constructor call the new (ignoring the regionname).  Add deprecated to the old constructor.  Thanks for doing this one.

> Action should not store or serialize regionName
> -----------------------------------------------
>
>                 Key: HBASE-3534
>                 URL: https://issues.apache.org/jira/browse/HBASE-3534
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ryan rawson
>            Assignee: Ted Yu
>             Fix For: 0.92.0
>
>         Attachments: 3534.txt
>
>
> Action stores the regionName, BUT an action comes from a MultiAction, which contains:
>   public Map<byte[], List<Action<R>>> actions 
> Which means we are storing the regionName multiple times. In fact, no one even calls the accessor getRegionName!
> It changes the serialization of Action and MultiAction, but reduces the byte overhead.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira