svn commit: r1581217 - /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/coprocessor/ColumnInterpreter.java

[te...@apache.org]

Author: tedyu
Date: Tue Mar 25 03:45:55 2014
New Revision: 1581217

URL: http://svn.apache.org/r1581217
Log:
HBASE-10821 Make ColumnInterpreter#getValue() abstract


Modified:
    hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/coprocessor/ColumnInterpreter.java

Modified: hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/coprocessor/ColumnInterpreter.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/coprocessor/ColumnInterpreter.java?rev=1581217&r1=1581216&r2=1581217&view=diff
==============================================================================
--- hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/coprocessor/ColumnInterpreter.java (original)
+++ hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/coprocessor/ColumnInterpreter.java Tue Mar 25 03:45:55 2014
@@ -60,7 +60,6 @@ public abstract class ColumnInterpreter<
 Q extends Message, R extends Message> {
 
   /**
-   * TODO: when removing {@link #getValue(byte[], byte[], KeyValue)}, this method should be made abstract
    * 
    * @param colFamily
    * @param colQualifier
@@ -68,24 +67,8 @@ Q extends Message, R extends Message> {
    * @return value of type T
    * @throws IOException
    */
-  public T getValue(byte[] colFamily, byte[] colQualifier, Cell c)
-      throws IOException {
-    // call the deprecated method for compatiblity.
-    KeyValue kv = KeyValueUtil.ensureKeyValue(c);
-    return getValue(colFamily, colQualifier, kv);
-  }
-
-  /**
-   * This method used to be abstract, and is preserved for compatibility and easy of conversion
-   * from 0.94->0.96.
-   *
-   * Please override {@link #getValue(byte[], byte[], Cell)} instead.
-   */
-  @Deprecated
-  public T getValue(byte[] colFamily, byte[] colQualifier, KeyValue kv)
-      throws IOException {
-    return null;
-  }
+  public abstract T getValue(byte[] colFamily, byte[] colQualifier, Cell c)
+      throws IOException;
 
   /**
    * @param l1