You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/23 05:39:36 UTC

[GitHub] [cloudstack] havengit commented on a change in pull request #4236: resolves issues Multiple Public Subnets static NAT

havengit commented on a change in pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#discussion_r528480021



##########
File path: systemvm/debian/opt/cloud/bin/configure.py
##########
@@ -964,6 +964,9 @@ def processStaticNatRule(self, rule):
         self.fw.append(["mangle", "front",
                         "-A PREROUTING -d %s/32 -m state --state NEW -j MARK --set-xmark %s/0xffffffff" %
                         (rule["public_ip"], hex(100 + int(device[len("eth"):])))])
+        self.fw.append(["mangle", "front",
+                        "-A PREROUTING -s %s/32 -m state --state NEW -i eth0 -j MARK --set-xmark %s/0xffffffff" %

Review comment:
       @DaanHoogland   yes, This PR only fixes the issue in isolated networks ,   Weizhou's PR was much more effective https://github.com/apache/cloudstack/pull/4484




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org