You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Norman Maurer <no...@apache.org> on 2009/08/14 19:33:53 UTC

SMTPServer rewrite comments

Hi all,

as you know I'm currently working on making the smtpserver of james
more extendable. I dedicided to use the "old work" of Stefano and me (
from the handlerapi-experiment sandbox) as base for that. I'm now
finish with the backporting (is backporting the right name for porting
it to trunk ;P ) of the "old" sandbox + fixing some minor bugs on it.
I think even in the current state its better then everything we ever
had in trunk as smtpserver. The current code can be found here:

http://svn.apache.org/repos/asf/james/server/sandbox/active/smtp_refactor/

I suggest to just merge it to trunk ( after I fixed the config file
stuff) and continue there with the work. But before that I would like
to ask you to take a look at it and see if you are ok with that.

When its in trunk I will start to "help" robert to work on the
container sandbox to modify the smtpserver to use guice for all the
wiring etc.

In the long term I would like to be able to realease the smtpserver as
independend "product" to give developers some light smtpserver which
is high extendable.

Thoughts ?

Bye,
Norman

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

Re: SMTPServer rewrite comments

Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Mon, Aug 17, 2009 at 4:53 PM, Norman Maurer<no...@apache.org> wrote:
> I think I will start to merge the sandbox to trunk tomorrow. If
> someone has concern raise them now ;)

cool

once you've done, i'll merge in the changes i made on the other branch
unless anyone jumps in before then with an objection

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

Re: SMTPServer rewrite comments

Posted by Norman Maurer <no...@apache.org>.
I think I will start to merge the sandbox to trunk tomorrow. If
someone has concern raise them now ;)

Bye,
Norman

2009/8/17 Norman Maurer <no...@apache.org>:
> Forgot to note that it will even start without ajust config.xml, so no
> configuration backward compatibilty problems at all (even if I don't
> care to much about this).
>
> Bye,
> Norman
>
>
>
> 2009/8/17 Robert Burrell Donkin <ro...@gmail.com>:
>> On Sat, Aug 15, 2009 at 8:11 AM, Norman Maurer<no...@apache.org> wrote:
>>> After thinkin a bit more about it, I thought It would be helpful to
>>> give you a small description about the "new" design ( just to make it
>>> a bit easier to understand). The new smtp fastfail stuff is now based
>>> on hooks. It similar to the design that qpsmtpd use ( See
>>> http://smtpd.develooper.com/). So my and Stefanos idea was, developers
>>> who want to write fastfail handlers should not need to implement a new
>>> CommandHandler for that. CommandHandler should only be used for
>>> implement new Commands ( sounds logic heh ?). So there are a few new
>>> interfaces (Hooks) who give the developer the possible to get stuff
>>> executed after the parsing on a command is done and before the final
>>> response (of the CommandHandler) is written to the smtp client.
>>>
>>> So here are the new hooks:
>>>
>>> AuthHook.java
>>> HeloHook.java
>>> MailHook.java
>>> MailParametersHook.java
>>> MessageHook.java
>>> QuitHook.java
>>> RcptHook.java
>>>
>>> So if a user wants (for example) check if the sender and recipient is
>>> the same and in this case reject the recipient he would implement the
>>> MailHook and RcptHook and do the checking in the there. I think that's
>>> much easier and clean then before.
>>
>> i'm in favour of this design approach
>>
>> - robert
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

Re: SMTPServer rewrite comments

Posted by Norman Maurer <no...@apache.org>.
Forgot to note that it will even start without ajust config.xml, so no
configuration backward compatibilty problems at all (even if I don't
care to much about this).

Bye,
Norman



2009/8/17 Robert Burrell Donkin <ro...@gmail.com>:
> On Sat, Aug 15, 2009 at 8:11 AM, Norman Maurer<no...@apache.org> wrote:
>> After thinkin a bit more about it, I thought It would be helpful to
>> give you a small description about the "new" design ( just to make it
>> a bit easier to understand). The new smtp fastfail stuff is now based
>> on hooks. It similar to the design that qpsmtpd use ( See
>> http://smtpd.develooper.com/). So my and Stefanos idea was, developers
>> who want to write fastfail handlers should not need to implement a new
>> CommandHandler for that. CommandHandler should only be used for
>> implement new Commands ( sounds logic heh ?). So there are a few new
>> interfaces (Hooks) who give the developer the possible to get stuff
>> executed after the parsing on a command is done and before the final
>> response (of the CommandHandler) is written to the smtp client.
>>
>> So here are the new hooks:
>>
>> AuthHook.java
>> HeloHook.java
>> MailHook.java
>> MailParametersHook.java
>> MessageHook.java
>> QuitHook.java
>> RcptHook.java
>>
>> So if a user wants (for example) check if the sender and recipient is
>> the same and in this case reject the recipient he would implement the
>> MailHook and RcptHook and do the checking in the there. I think that's
>> much easier and clean then before.
>
> i'm in favour of this design approach
>
> - robert
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

Re: SMTPServer rewrite comments

Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Sat, Aug 15, 2009 at 8:11 AM, Norman Maurer<no...@apache.org> wrote:
> After thinkin a bit more about it, I thought It would be helpful to
> give you a small description about the "new" design ( just to make it
> a bit easier to understand). The new smtp fastfail stuff is now based
> on hooks. It similar to the design that qpsmtpd use ( See
> http://smtpd.develooper.com/). So my and Stefanos idea was, developers
> who want to write fastfail handlers should not need to implement a new
> CommandHandler for that. CommandHandler should only be used for
> implement new Commands ( sounds logic heh ?). So there are a few new
> interfaces (Hooks) who give the developer the possible to get stuff
> executed after the parsing on a command is done and before the final
> response (of the CommandHandler) is written to the smtp client.
>
> So here are the new hooks:
>
> AuthHook.java
> HeloHook.java
> MailHook.java
> MailParametersHook.java
> MessageHook.java
> QuitHook.java
> RcptHook.java
>
> So if a user wants (for example) check if the sender and recipient is
> the same and in this case reject the recipient he would implement the
> MailHook and RcptHook and do the checking in the there. I think that's
> much easier and clean then before.

i'm in favour of this design approach

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

Re: SMTPServer rewrite comments

Posted by Norman Maurer <no...@apache.org>.
After thinkin a bit more about it, I thought It would be helpful to
give you a small description about the "new" design ( just to make it
a bit easier to understand). The new smtp fastfail stuff is now based
on hooks. It similar to the design that qpsmtpd use ( See
http://smtpd.develooper.com/). So my and Stefanos idea was, developers
who want to write fastfail handlers should not need to implement a new
CommandHandler for that. CommandHandler should only be used for
implement new Commands ( sounds logic heh ?). So there are a few new
interfaces (Hooks) who give the developer the possible to get stuff
executed after the parsing on a command is done and before the final
response (of the CommandHandler) is written to the smtp client.

So here are the new hooks:

AuthHook.java
HeloHook.java
MailHook.java
MailParametersHook.java
MessageHook.java
QuitHook.java
RcptHook.java

So if a user wants (for example) check if the sender and recipient is
the same and in this case reject the recipient he would implement the
MailHook and RcptHook and do the checking in the there. I think that's
much easier and clean then before.

Hope this helps..

Bye,
Norman

2009/8/14 Norman Maurer <no...@apache.org>:
> Hi all,
>
> as you know I'm currently working on making the smtpserver of james
> more extendable. I dedicided to use the "old work" of Stefano and me (
> from the handlerapi-experiment sandbox) as base for that. I'm now
> finish with the backporting (is backporting the right name for porting
> it to trunk ;P ) of the "old" sandbox + fixing some minor bugs on it.
> I think even in the current state its better then everything we ever
> had in trunk as smtpserver. The current code can be found here:
>
> http://svn.apache.org/repos/asf/james/server/sandbox/active/smtp_refactor/
>
> I suggest to just merge it to trunk ( after I fixed the config file
> stuff) and continue there with the work. But before that I would like
> to ask you to take a look at it and see if you are ok with that.
>
> When its in trunk I will start to "help" robert to work on the
> container sandbox to modify the smtpserver to use guice for all the
> wiring etc.
>
> In the long term I would like to be able to realease the smtpserver as
> independend "product" to give developers some light smtpserver which
> is high extendable.
>
> Thoughts ?
>
> Bye,
> Norman
>

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

Re: SMTPServer rewrite comments

Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Fri, Aug 14, 2009 at 6:33 PM, Norman Maurer<no...@apache.org> wrote:
> Hi all,
>
> as you know I'm currently working on making the smtpserver of james
> more extendable. I dedicided to use the "old work" of Stefano and me (
> from the handlerapi-experiment sandbox) as base for that. I'm now
> finish with the backporting (is backporting the right name for porting
> it to trunk ;P ) of the "old" sandbox + fixing some minor bugs on it.
> I think even in the current state its better then everything we ever
> had in trunk as smtpserver. The current code can be found here:
>
> http://svn.apache.org/repos/asf/james/server/sandbox/active/smtp_refactor/
>
> I suggest to just merge it to trunk ( after I fixed the config file
> stuff) and continue there with the work. But before that I would like
> to ask you to take a look at it and see if you are ok with that.
>
> When its in trunk I will start to "help" robert to work on the
> container sandbox to modify the smtpserver to use guice for all the
> wiring etc.

i'd rather do this in trunk

> In the long term I would like to be able to realease the smtpserver as
> independend "product" to give developers some light smtpserver which
> is high extendable.

i'm keen on this too

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

fashion Obama Air force fusion,jordan shoes,Air max 91,Ed Hardy bags,Air max,

Posted by 159shoes <sh...@hotmail.com>.
top quality,safe shipping,sincerity serince,perfect prices!!
we have those clothes for sale ,welcome to order things here!!   
1)jean:bape jean,bbc jean,Red monkey jeans ,D&G Jeans ,Artful dodger jeans
,G-star jeans ,LRG jeans ,BBC Jeans ,Diesel 
 AKA STASH HOUSE ,coogi jeans, armani jean,

2)Hoody:. hoody,Bbc hoody,Gino Green Grobal,lrg hoody,10deep Hoody,ed hardy
hoody,Coogi hoody, arftful dodger hoody 
 ,CLH hoody ,NY hoody, LA hoody ,G-star hoody,Christan auaigier hoody, new
styles hoody,kidrobot hoody, new era hoody, 

3)T-shirt:. t-shirt, Bape t-shirt, Lacoste T-shirt, Polo T-Shirt, GGG
T-shirt,coogi t-shirt, LRG T-shirt,D&G T-Shirts, Burberry T-shirt, ed hardy
t-shirt, artful dodger t-shirt, Armani t-shirt,A&F T-shirt,BOSS T-shirt      
 
4)sweater: lacoste sweater ,Polo Sweater,Armani sweater 

5)jacket: A&F men jacket, A&F women coat , Adidas jacket , D&g Jacket , Polo
jacket ,Burberry jacket 

  website: www.shoes159.com
  MSN:sell-apparel@hotmail.com

-- 
View this message in context: http://www.nabble.com/SMTPServer-rewrite-comments-tp24975670p25018777.html
Sent from the James - Dev mailing list archive at Nabble.com.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org