You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "luoyuxia (via GitHub)" <gi...@apache.org> on 2025/12/28 04:32:53 UTC

[I] Introduce CompactedRowWriter [fluss-rust]

luoyuxia opened a new issue, #118:
URL: https://github.com/apache/fluss-rust/issues/118

   ### Search before asking
   
   - [x] I searched in the [issues](https://github.com/apache/fluss-rust/issues) and found nothing similar.
   
   
   ### Description
   
   as title. Please refer to https://github.com/apache/fluss/blob/d4a72fad240d4b81563aaf83fa3b09b5058674ed/fluss-common/src/main/java/org/apache/fluss/row/compacted/CompactedRowWriter.java#L71
   
   ### Willingness to contribute
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Introduce CompactedRowWriter [fluss-rust]

Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on issue #118:
URL: https://github.com/apache/fluss-rust/issues/118#issuecomment-3698017211

   > Just to confirm, I should only submit the `CompactedRowWriter` for this task? It depends on the `CompactedRow` as well isn't it? So should I raise the PR for [#110](https://github.com/apache/fluss-rust/issues/110) firstly?
   
   Yes, you should only submit the `CompactedRowWriter` for this task. 
   I think `CompactedRow` depends on `CompactedRowWriter` since `CompactedRowWriter` is write bytes in compacted way, and `CompactedRow` is to parse the bytes to row value.
   But anyway, it depends on you since you're the code developer. Feel free to take ways that's convenient for you .
   
   > Also, for the design, should the writer own the buffer like the Java implementation? Or it should just borrow it and own the "view" of the bytes.
   
   I think the writer own the buffer.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Introduce CompactedRowWriter [fluss-rust]

Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia closed issue #118: Introduce CompactedRowWriter
URL: https://github.com/apache/fluss-rust/issues/118


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Introduce CompactedRowWriter [fluss-rust]

Posted by "Kelvinyu1117 (via GitHub)" <gi...@apache.org>.
Kelvinyu1117 commented on issue #118:
URL: https://github.com/apache/fluss-rust/issues/118#issuecomment-3696404143

   Just to confirm, I should only submit the `CompactedRowWriter` for this task?
   It depends on the `CompactedRow` as well isn't it? So should I raise the PR for #110 firstly?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org