You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by manishgupta88 <gi...@git.apache.org> on 2018/07/26 09:26:01 UTC

[GitHub] carbondata pull request #2441: [CARBONDATA-2625] optimize CarbonReader perfo...

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2441#discussion_r205388461
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java ---
    @@ -647,6 +648,11 @@ private int getKeySize(List<ProjectionDimension> queryDimension,
           // must stop all the running execution otherwise it will keep running and will hit
           // the query performance.
           queryProperties.executorService.shutdownNow();
    +      try {
    +        queryProperties.executorService.awaitTermination(1, TimeUnit.HOURS);
    +      } catch (InterruptedException e) {
    +        e.printStackTrace();
    --- End diff --
    
    Remove this and use logger


---