You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/16 10:28:54 UTC

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4330: Support All SQL for SQL92 with visitor

terrymanu opened a new pull request #4330: Support All SQL for SQL92 with visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4330
 
 
   Fixes ##4329.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4330: Support All SQL for SQL92 with visitor

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4330: Support All SQL for SQL92 with visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4330#issuecomment-586692408
 
 
   ## Pull Request Test Coverage Report for [Build 1755](https://coveralls.io/builds/28758170)
   
   * **0** of **465**   **(0.0%)**  changed or added relevant lines in **6** files are covered.
   * **82** unchanged lines in **6** files lost coverage.
   * Overall coverage decreased (**-1.5%**) to **57.638%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92TCLVisitor.java](https://coveralls.io/builds/28758170/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92TCLVisitor.java#L34) | 0 | 4 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/SQL92ParserEntry.java](https://coveralls.io/builds/28758170/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FSQL92ParserEntry.java#L56) | 0 | 9 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DCLVisitor.java](https://coveralls.io/builds/28758170/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DCLVisitor.java#L37) | 0 | 16 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DDLVisitor.java](https://coveralls.io/builds/28758170/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DDLVisitor.java#L58) | 0 | 99 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQL92Visitor.java](https://coveralls.io/builds/28758170/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FSQL92Visitor.java#L100) | 0 | 164 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DMLVisitor.java](https://coveralls.io/builds/28758170/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DMLVisitor.java#L89) | 0 | 173 | 0.0%
   <!-- | **Total:** | **0** | **465** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerDDLVisitor.java](https://coveralls.io/builds/28758170/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerDDLVisitor.java#L101) | 1 | 0% |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28758170/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/ShardingOrchestrationFacade.java](https://coveralls.io/builds/28758170/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Fregistry%2FShardingOrchestrationFacade.java#L127) | 3 | 93.62% |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28758170/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L62) | 12 | 61.11% |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/wrapper/ApolloOpenApiWrapper.java](https://coveralls.io/builds/28758170/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2Fwrapper%2FApolloOpenApiWrapper.java#L59) | 18 | 0% |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/main/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperInstance.java](https://coveralls.io/builds/28758170/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-zookeeper-curator%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FCuratorZookeeperInstance.java#L99) | 46 | 45.97% |
   <!-- | **Total:** | **82** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28758170/badge)](https://coveralls.io/builds/28758170) |
   | :-- | --: |
   | Change from base [Build 9574](https://coveralls.io/builds/28756767): |  -1.5% |
   | Covered Lines: | 11059 |
   | Relevant Lines: | 19187 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4330: Support All SQL for SQL92 with visitor

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4330: Support All SQL for SQL92 with visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4330#issuecomment-586692408
 
 
   ## Pull Request Test Coverage Report for [Build 9577](https://coveralls.io/builds/28757985)
   
   * **0** of **465**   **(0.0%)**  changed or added relevant lines in **6** files are covered.
   * **1** unchanged line in **1** file lost coverage.
   * Overall coverage decreased (**-1.4%**) to **57.681%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92TCLVisitor.java](https://coveralls.io/builds/28757985/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92TCLVisitor.java#L34) | 0 | 4 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/SQL92ParserEntry.java](https://coveralls.io/builds/28757985/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FSQL92ParserEntry.java#L56) | 0 | 9 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DCLVisitor.java](https://coveralls.io/builds/28757985/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DCLVisitor.java#L37) | 0 | 16 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DDLVisitor.java](https://coveralls.io/builds/28757985/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DDLVisitor.java#L58) | 0 | 99 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQL92Visitor.java](https://coveralls.io/builds/28757985/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FSQL92Visitor.java#L100) | 0 | 164 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DMLVisitor.java](https://coveralls.io/builds/28757985/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DMLVisitor.java#L89) | 0 | 173 | 0.0%
   <!-- | **Total:** | **0** | **465** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerDDLVisitor.java](https://coveralls.io/builds/28757985/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerDDLVisitor.java#L101) | 1 | 0% |
   <!-- | **Total:** | **1** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28757985/badge)](https://coveralls.io/builds/28757985) |
   | :-- | --: |
   | Change from base [Build 9574](https://coveralls.io/builds/28756767): |  -1.4% |
   | Covered Lines: | 11084 |
   | Relevant Lines: | 19216 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4330: Support All SQL for SQL92 with visitor

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4330: Support All SQL for SQL92 with visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4330#issuecomment-586692113
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330?src=pr&el=h1) Report
   > Merging [#4330](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/0438ce9d700c672fb7fa5382220490f71d9fe3fc?src=pr&el=desc) will **decrease** coverage by `1.28%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4330      +/-   ##
   ============================================
   - Coverage      55.5%   54.22%   -1.29%     
     Complexity      352      352              
   ============================================
     Files          1032     1045      +13     
     Lines         18723    19216     +493     
     Branches       3420     3531     +111     
   ============================================
   + Hits          10393    10419      +26     
   - Misses         7675     8142     +467     
     Partials        655      655
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/sql/parser/visitor/impl/SQLServerDDLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbHNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL2ltcGwvU1FMU2VydmVyRERMVmlzaXRvci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ardingsphere/sql/parser/visitor/OracleVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW9yYWNsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL09yYWNsZVZpc2l0b3IuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ingsphere/sql/parser/visitor/SQLServerVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbHNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL1NRTFNlcnZlclZpc2l0b3IuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...hardingsphere/sql/parser/visitor/SQL92Visitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbDkyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvU1FMOTJWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...phere/sql/parser/visitor/impl/SQL92DCLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbDkyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9TUUw5MkRDTFZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...phere/sql/parser/visitor/impl/SQL92DDLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbDkyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9TUUw5MkRETFZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...he/shardingsphere/sql/parser/SQL92ParserEntry.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbDkyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL1NRTDkyUGFyc2VyRW50cnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...phere/sql/parser/visitor/impl/SQL92TCLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbDkyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9TUUw5MlRDTFZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...phere/sql/parser/visitor/impl/SQL92DMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbDkyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9TUUw5MkRNTFZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [.../orchestration/center/instance/ApolloInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL0Fwb2xsb0luc3RhbmNlLmphdmE=) | `54.05% <0%> (-1.51%)` | `0% <0%> (ø)` | |
   | ... and [18 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330?src=pr&el=footer). Last update [0438ce9...b35c629](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4330: Support All SQL for SQL92 with visitor

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4330: Support All SQL for SQL92 with visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4330#issuecomment-586692408
 
 
   ## Pull Request Test Coverage Report for [Build 1754](https://coveralls.io/builds/28758007)
   
   * **0** of **465**   **(0.0%)**  changed or added relevant lines in **6** files are covered.
   * **3** unchanged lines in **2** files lost coverage.
   * Overall coverage decreased (**-1.4%**) to **57.692%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92TCLVisitor.java](https://coveralls.io/builds/28758007/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92TCLVisitor.java#L34) | 0 | 4 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/SQL92ParserEntry.java](https://coveralls.io/builds/28758007/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FSQL92ParserEntry.java#L56) | 0 | 9 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DCLVisitor.java](https://coveralls.io/builds/28758007/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DCLVisitor.java#L37) | 0 | 16 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DDLVisitor.java](https://coveralls.io/builds/28758007/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DDLVisitor.java#L58) | 0 | 99 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQL92Visitor.java](https://coveralls.io/builds/28758007/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FSQL92Visitor.java#L100) | 0 | 164 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DMLVisitor.java](https://coveralls.io/builds/28758007/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DMLVisitor.java#L89) | 0 | 173 | 0.0%
   <!-- | **Total:** | **0** | **465** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerDDLVisitor.java](https://coveralls.io/builds/28758007/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerDDLVisitor.java#L101) | 1 | 0% |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28758007/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28758007/badge)](https://coveralls.io/builds/28758007) |
   | :-- | --: |
   | Change from base [Build 9574](https://coveralls.io/builds/28756767): |  -1.4% |
   | Covered Lines: | 11086 |
   | Relevant Lines: | 19216 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4330: Support All SQL for SQL92 with visitor

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4330: Support All SQL for SQL92 with visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4330
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services