You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by al...@apache.org on 2026/02/09 02:12:17 UTC

(dubbo-go) branch develop updated: refactor: remove config package dependency from health and reflection services (#3197)

This is an automated email from the ASF dual-hosted git repository.

alexstocks pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/dubbo-go.git


The following commit(s) were added to refs/heads/develop by this push:
     new f9f210ed9 refactor: remove config package dependency from health and reflection services (#3197)
f9f210ed9 is described below

commit f9f210ed912faa1865316d8792843a065a646a9b
Author: CAICAII <33...@qq.com>
AuthorDate: Mon Feb 9 10:12:12 2026 +0800

    refactor: remove config package dependency from health and reflection services (#3197)
    
    Remove dependencies on config package from:
    - protocol/triple/health/healthServer.go
    - protocol/triple/reflection/serverreflection.go
    
    Both services already register via server.SetProviderServices() in init(),
    so config.SetProviderServiceWithInfo() calls are no longer needed.
    
    Relates to #2741
    
    Signed-off-by: Sisyphus <si...@apache.org>
---
 protocol/triple/health/healthServer.go         | 4 ----
 protocol/triple/reflection/serverreflection.go | 4 ----
 2 files changed, 8 deletions(-)

diff --git a/protocol/triple/health/healthServer.go b/protocol/triple/health/healthServer.go
index 4b1d551b5..d2791fa1c 100644
--- a/protocol/triple/health/healthServer.go
+++ b/protocol/triple/health/healthServer.go
@@ -31,7 +31,6 @@ import (
 
 import (
 	"dubbo.apache.org/dubbo-go/v3/common/constant"
-	"dubbo.apache.org/dubbo-go/v3/config"
 	"dubbo.apache.org/dubbo-go/v3/internal"
 	"dubbo.apache.org/dubbo-go/v3/protocol/triple/health/triple_health"
 	"dubbo.apache.org/dubbo-go/v3/server"
@@ -186,9 +185,6 @@ func init() {
 		Priority: constant.DefaultPriority,
 	})
 
-	// In order to adapt config.Load
-	// Plans for future removal
-	config.SetProviderServiceWithInfo(healthServer, &triple_health.Health_ServiceInfo)
 }
 
 func SetServingStatusServing(service string) {
diff --git a/protocol/triple/reflection/serverreflection.go b/protocol/triple/reflection/serverreflection.go
index 63a514b4a..cf22679b4 100644
--- a/protocol/triple/reflection/serverreflection.go
+++ b/protocol/triple/reflection/serverreflection.go
@@ -38,7 +38,6 @@ import (
 
 import (
 	"dubbo.apache.org/dubbo-go/v3/common/constant"
-	"dubbo.apache.org/dubbo-go/v3/config"
 	"dubbo.apache.org/dubbo-go/v3/internal"
 	"dubbo.apache.org/dubbo-go/v3/internal/reflection"
 	rpb "dubbo.apache.org/dubbo-go/v3/protocol/triple/reflection/triple_reflection"
@@ -278,9 +277,6 @@ func init() {
 		},
 		Priority: constant.DefaultPriority,
 	})
-	// In order to adapt config.Load
-	// Plans for future removal
-	config.SetProviderServiceWithInfo(reflectionServer, &rpb.ServerReflection_ServiceInfo)
 }
 
 func Register(s reflection.ServiceInfoProvider) {