You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/09/04 03:47:58 UTC
Re: Review Request 60492: Added a `network/ports` isolator skeleton.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60492/#review184476
-----------------------------------------------------------
Fix it, then Ship it!
src/Makefile.am
Lines 1361-1363 (patched)
<https://reviews.apache.org/r/60492/#comment260624>
These 3 lines should be moved to line 1344.
- Qian Zhang
On Aug. 15, 2017, 7:34 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60492/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 7:34 a.m.)
>
>
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
>
>
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the skeleton of the `network/ports` isolator and wired it up
> to the autotools build. Added the --enable-network-ports-isolator
> configuration option to build the isolator and check for the libnl3
> dependencies.
>
>
> Diffs
> -----
>
> configure.ac 92bc1aa5f9604e3b2b678225a57622cd2eb8679a
> src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b
> src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/60492/diff/12/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>