You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2021/07/10 02:13:17 UTC

[incubator-doris] branch master updated: [Log] Optimize delete error message (#6187)

This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 3ad12c5  [Log] Optimize delete error message (#6187)
3ad12c5 is described below

commit 3ad12c5f8a46bb90d737666208190bace3575451
Author: qiye <ji...@gmail.com>
AuthorDate: Sat Jul 10 10:13:08 2021 +0800

    [Log] Optimize delete error message (#6187)
    
    ## Proposed changes
    
    When a delete error occurs, the error message is ambiguous.
    
    ```sql
    mysql> DELETE FROM nebula_trade_health_trade PARTITION q3_2021 WHERE event_day = '20210706';
    ERROR 1064 (HY000): errCode = 2, detailMessage = failed to execute delete. transaction id 7215554, timeout(ms) 160000, unfinished replicas: 4718319=7345841
    ```
    
    We do not know the meaning of `4718319=7345841`.
    
    Actually the former is `BackendId` and the latter is `TabletId`.
    
    I'll add an instruction here to help locate the problem quickly. The error message will be
    
    ```sql
    ERROR 1064 (HY000): errCode = 2, detailMessage = failed to execute delete. transaction id 7215554, timeout(ms) 160000, unfinished replicas [BackendId=TabletId]: 4718319=7345841
    ```
---
 fe/fe-core/src/main/java/org/apache/doris/load/DeleteHandler.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/load/DeleteHandler.java b/fe/fe-core/src/main/java/org/apache/doris/load/DeleteHandler.java
index 1c80d72..9aea5af 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/load/DeleteHandler.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/load/DeleteHandler.java
@@ -284,7 +284,7 @@ public class DeleteHandler implements Writable {
                 // only show at most 5 results
                 List<Entry<Long, Long>> subList = unfinishedMarks.subList(0, Math.min(unfinishedMarks.size(), 5));
                 if (!subList.isEmpty()) {
-                    errMsg = "unfinished replicas: " + Joiner.on(", ").join(subList);
+                    errMsg = "unfinished replicas [BackendId=TabletId]: " + Joiner.on(", ").join(subList);
                 }
                 LOG.warn(errMsg);
 

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org