You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/13 03:07:42 UTC
[GitHub] [spark] beliefer opened a new pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
beliefer opened a new pull request #30021:
URL: https://github.com/apache/spark/pull/30021
### What changes were proposed in this pull request?
Except for Postgresql, other data sources (for example: vertica, oracle, redshift, mysql, presto) are not allowed to specify window frame for the Lead and Lag functions.
But the current error message is not clear enough.
`Window Frame $f must match the required frame`
This PR will use the following error message.
`Cannot specify window frame for lead function`
### Why are the changes needed?
Make clear error message.
### Does this PR introduce _any_ user-facing change?
Yes
Users will see the clearer error message.
### How was this patch tested?
Jenkins test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707563720
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34336/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707481521
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34332/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707537568
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707552050
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34336/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707468068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707550448
**[Test build #129732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129732/testReport)** for PR 30021 at commit [`e0af70d`](https://github.com/apache/spark/commit/e0af70d447f96a43e231dbb8602a1a53d47358c0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707479031
**[Test build #129725 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129725/testReport)** for PR 30021 at commit [`e3c90cf`](https://github.com/apache/spark/commit/e3c90cff4058cea3cec49905cab28022d8c46d96).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707467211
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34329/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707457646
**[Test build #129723 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129723/testReport)** for PR 30021 at commit [`a10ae2f`](https://github.com/apache/spark/commit/a10ae2fd1ac2a14b11b6675c01014d6ea0ad16c9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707481533
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707457646
**[Test build #129723 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129723/testReport)** for PR 30021 at commit [`a10ae2f`](https://github.com/apache/spark/commit/a10ae2fd1ac2a14b11b6675c01014d6ea0ad16c9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707694895
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707728313
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707694000
**[Test build #129732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129732/testReport)** for PR 30021 at commit [`e0af70d`](https://github.com/apache/spark/commit/e0af70d447f96a43e231dbb8602a1a53d47358c0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707476349
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34332/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30021:
URL: https://github.com/apache/spark/pull/30021#discussion_r503643245
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -2974,9 +2974,9 @@ class Analyzer(
*/
object ResolveWindowFrame extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan resolveExpressions {
- case WindowExpression(wf: WindowFunction, WindowSpecDefinition(_, _, f: SpecifiedWindowFrame))
Review comment:
We should still keep this case, maybe other functions can hit it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707583723
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #30021:
URL: https://github.com/apache/spark/pull/30021#discussion_r503643546
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -2974,9 +2974,9 @@ class Analyzer(
*/
object ResolveWindowFrame extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan resolveExpressions {
- case WindowExpression(wf: WindowFunction, WindowSpecDefinition(_, _, f: SpecifiedWindowFrame))
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707462315
**[Test build #129725 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129725/testReport)** for PR 30021 at commit [`e3c90cf`](https://github.com/apache/spark/commit/e3c90cff4058cea3cec49905cab28022d8c46d96).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707583723
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707532094
**[Test build #129730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129730/testReport)** for PR 30021 at commit [`ab5de89`](https://github.com/apache/spark/commit/ab5de8995a3cfb3a5df856f8b93841f42737dc67).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30021:
URL: https://github.com/apache/spark/pull/30021#discussion_r503643542
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -2974,9 +2974,9 @@ class Analyzer(
*/
object ResolveWindowFrame extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan resolveExpressions {
- case WindowExpression(wf: WindowFunction, WindowSpecDefinition(_, _, f: SpecifiedWindowFrame))
- if wf.frame != UnspecifiedFrame && wf.frame != f =>
- failAnalysis(s"Window Frame $f must match the required frame ${wf.frame}")
+ case WindowExpression(owf: OffsetWindowFunction,
+ WindowSpecDefinition(_, _, _: SpecifiedWindowFrame)) =>
Review comment:
`OffsetWindowFunction` can use `UnspecifiedFrame` now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707563713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707462315
**[Test build #129725 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129725/testReport)** for PR 30021 at commit [`e3c90cf`](https://github.com/apache/spark/commit/e3c90cff4058cea3cec49905cab28022d8c46d96).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707563713
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #30021:
URL: https://github.com/apache/spark/pull/30021
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707479171
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707481533
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707532094
**[Test build #129730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129730/testReport)** for PR 30021 at commit [`ab5de89`](https://github.com/apache/spark/commit/ab5de8995a3cfb3a5df856f8b93841f42737dc67).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707550448
**[Test build #129732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129732/testReport)** for PR 30021 at commit [`e0af70d`](https://github.com/apache/spark/commit/e0af70d447f96a43e231dbb8602a1a53d47358c0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707468068
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707537568
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #30021:
URL: https://github.com/apache/spark/pull/30021#discussion_r503726517
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -2974,9 +2974,9 @@ class Analyzer(
*/
object ResolveWindowFrame extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan resolveExpressions {
- case WindowExpression(wf: WindowFunction, WindowSpecDefinition(_, _, f: SpecifiedWindowFrame))
- if wf.frame != UnspecifiedFrame && wf.frame != f =>
- failAnalysis(s"Window Frame $f must match the required frame ${wf.frame}")
+ case WindowExpression(owf: OffsetWindowFunction,
+ WindowSpecDefinition(_, _, _: SpecifiedWindowFrame)) =>
Review comment:
I got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707479171
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707468073
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129723/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707573471
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34338/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-708403326
@cloud-fan Thanks for your help!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707474058
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707474058
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707537578
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129730/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707537460
**[Test build #129730 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129730/testReport)** for PR 30021 at commit [`ab5de89`](https://github.com/apache/spark/commit/ab5de8995a3cfb3a5df856f8b93841f42737dc67).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707563689
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34336/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707583683
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34338/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707694895
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707479180
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129725/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707474046
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34329/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30021: [SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30021:
URL: https://github.com/apache/spark/pull/30021#issuecomment-707467921
**[Test build #129723 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129723/testReport)** for PR 30021 at commit [`a10ae2f`](https://github.com/apache/spark/commit/a10ae2fd1ac2a14b11b6675c01014d6ea0ad16c9).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org