[impala] branch master updated: IMPALA-10111: Improve TestWebPage::test_query_stmt logging

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new eef6eb077 IMPALA-10111: Improve TestWebPage::test_query_stmt logging
eef6eb077 is described below

commit eef6eb077574b50c81510f303b90a3f69890db3c
Author: Tamas Mate <tm...@apache.org>
AuthorDate: Fri Apr 22 13:39:07 2022 +0200

    IMPALA-10111: Improve TestWebPage::test_query_stmt logging
    
    TestWebPage::test_query_stmt is flaky, to better understand the root
    cause of this test failure this commit adds the web page JSON result
    to the error message.
    
    Testing:
     - Executed the test locally.
    
    Change-Id: Id7ddd04f72790440bba4546c48656c9fe68b4fd9
    Reviewed-on: http://gerrit.cloudera.org:8080/18442
    Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/webserver/test_web_pages.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/webserver/test_web_pages.py b/tests/webserver/test_web_pages.py
index 8defb25e5..36ae0fd1d 100644
--- a/tests/webserver/test_web_pages.py
+++ b/tests/webserver/test_web_pages.py
@@ -20,6 +20,7 @@ from tests.common.file_utils import grep_dir
 from tests.common.skip import SkipIfBuildType, SkipIfDockerizedCluster
 from tests.common.impala_cluster import ImpalaCluster
 from tests.common.impala_test_suite import ImpalaTestSuite
+from datetime import datetime
 import itertools
 import json
 import os
@@ -478,7 +479,8 @@ class TestWebPage(ImpalaTestSuite):
       if expected_result in json_part['stmt']:
         check_if_contains = True
         break
-    assert check_if_contains, "No matching statement found in the jsons."
+    assert check_if_contains, "No matching statement found in the jsons at {}: {}".format(
+        datetime.now(), response_json)
 
   def __run_query_and_get_debug_page(self, query, page_url, query_options=None,
                                      expected_state=None):