You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "DL1231 (via GitHub)" <gi...@apache.org> on 2025/10/10 18:05:10 UTC
[PR] MINOR: fix some tasks in build.gradle after Gradle version upgrade 8 -->> 9 [kafka]
DL1231 opened a new pull request, #20684:
URL: https://github.com/apache/kafka/pull/20684
1. Fix the task `unitTest` and `integrationTest`;
2. Add the `--no-parallel` option to the `aggregatedJavadoc` task;
3. Change the `name` to a method call `name()` for `KeepAliveMode`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: fix some tasks in build.gradle after Gradle version upgrade 8 -->> 9 [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #20684:
URL: https://github.com/apache/kafka/pull/20684#issuecomment-3394722412
> let me digg around this one.
go ahead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: fix some tasks in build.gradle after Gradle version upgrade 8 -->> 9 [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #20684:
URL: https://github.com/apache/kafka/pull/20684#issuecomment-3394724098
Wrong place for s comment, mobile GitHub app is not precise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: fix some tasks in build.gradle after Gradle version upgrade 8 -->> 9 [kafka]
Posted by "DL1231 (via GitHub)" <gi...@apache.org>.
DL1231 commented on PR #20684:
URL: https://github.com/apache/kafka/pull/20684#issuecomment-3392720351
Task` unitTest` and `integrationTest` before fix:
<img width="464" height="109" alt="FBD368A4-20CF-468E-DDB7-0D36DB74D89A" src="https://github.com/user-attachments/assets/8f2c25a5-9d6e-4f15-8ca3-7e773e8b2bc5" />
<img width="449" height="91" alt="B1775469-C977-4AED-917F-383489D2A047" src="https://github.com/user-attachments/assets/fdbae563-0825-47c3-a81d-e7dfe4f4fbad" />
after fix:
<img width="453" height="181" alt="71AA7C0F-E2B7-48AB-DBBA-A7A42F6FCC63" src="https://github.com/user-attachments/assets/ba1c2fe9-0b5d-4b25-b8f3-b9ddcefad4ed" />
<img width="452" height="114" alt="C7B68749-EE60-49A5-C794-C0E879442BEC" src="https://github.com/user-attachments/assets/e880b161-aa7a-4425-959c-a003feae32ac" />
Task aggregatedJavadoc before fix:
<img width="1210" height="52" alt="E8211113-66AD-41DE-B0CD-0CE3ECA5D553" src="https://github.com/user-attachments/assets/814b1855-4e33-439c-b399-01f583da1aa7" />
after fix:
<img width="1744" height="370" alt="BA121145-C579-48C8-B44A-1EDC06AD35CD" src="https://github.com/user-attachments/assets/03f63d32-0007-4c8b-8498-08bbff2bea8e" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: fix some tasks in build.gradle after Gradle version upgrade 8 -->> 9 [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #20684:
URL: https://github.com/apache/kafka/pull/20684#issuecomment-3394742111
> Perhaps we could add -Xlint:-path for the core module.
This should do the trick :crossed_fingers:
And please pardon me for spamming via GitHuib mobile app above :slightly_smiling_face:
Will be around, summon me if you need some help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: fix some tasks in build.gradle after Gradle version upgrade 8 -->> 9 [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #20684:
URL: https://github.com/apache/kafka/pull/20684#issuecomment-3394730361
Otherwise, we will file a patch to add `-Xlint:-path`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: fix some tasks in build.gradle after Gradle version upgrade 8 -->> 9 [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #20684:
URL: https://github.com/apache/kafka/pull/20684#issuecomment-3391679097
@DL1231 thanks for this patch. Please verify the fixed tasks on your local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: fix some tasks in build.gradle after Gradle version upgrade 8 -->> 9 [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #20684:
URL: https://github.com/apache/kafka/pull/20684#issuecomment-3394124132
Seems legit :white_check_mark:
Sugegstion for @DL1231 maybe you can save a few lines like this: https://github.com/apache/kafka/pull/20690/commits/18db4af662449e774c28b7b0bc3a6c4a8046f62c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: fix some tasks in build.gradle after Gradle version upgrade 8 -->> 9 [kafka]
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #20684:
URL: https://github.com/apache/kafka/pull/20684#issuecomment-3394720368
@chia7712 let me digg around this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: fix some tasks in build.gradle after Gradle version upgrade 8 -->> 9 [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #20684:
URL: https://github.com/apache/kafka/pull/20684#issuecomment-3394713911
```
./gradlew build -x test -PkeepAliveMode=session
```
This command is also failing. The related warnings stems from #10485, which enabled joint compilation. In addition, #16965 added the `-Werror` flag, which causes the warning to fail the build.
Perhaps we could add `-Xlint:-path` for the core module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: fix some tasks in build.gradle after Gradle version upgrade 8 -->> 9 [kafka]
Posted by "apalan60 (via GitHub)" <gi...@apache.org>.
apalan60 commented on PR #20684:
URL: https://github.com/apache/kafka/pull/20684#issuecomment-3395901967
> ```
> ./gradlew build -x test -PkeepAliveMode=session
> ```
>
> This command is also failing. The related warnings stems from #10485, which enabled joint compilation. In addition, #16965 added the `-Werror` flag, which causes the warning to fail the build.
>
> Perhaps we could add `-Xlint:-path` for the core module.
Thanks for the discussion. I’ve opened a PR https://github.com/apache/kafka/pull/20695 to address this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: fix some tasks in build.gradle after Gradle version upgrade 8 -->> 9 [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #20684:
URL: https://github.com/apache/kafka/pull/20684#issuecomment-3394729272
> Wrong place for s comment, mobile GitHub app is not precise.
don't worry. please file a PR for https://github.com/apache/kafka/pull/20684#issuecomment-3394713911 if you have other approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: fix some tasks in build.gradle after Gradle version upgrade 8 -->> 9 [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #20684:
URL: https://github.com/apache/kafka/pull/20684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org