You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by britter <gi...@git.apache.org> on 2016/10/03 16:07:10 UTC
[GitHub] maven-surefire pull request #125: Consistently rename JUnit 4.x integration ...
GitHub user britter opened a pull request:
https://github.com/apache/maven-surefire/pull/125
Consistently rename JUnit 4.x integration tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/britter/maven-surefire naming-conventions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #125
----
commit 7d0ef3306d16c77c6b241eae86c6555853b24634
Author: Benedikt Ritter <br...@apache.org>
Date: 2016-10-03T16:06:38Z
Consistently rename JUnit 4.x integration tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #125: Consistently rename JUnit 4.x integration tests
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/125
@Tibor17 rebased with master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #125: Consistently rename JUnit 4.x integration ...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/125#discussion_r81810117
--- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/JUnit47ConcurrencyIT.java ---
@@ -32,14 +32,14 @@
*
* @author Kristian Rosenvold
*/
-public class Junit47concurrencyIT
--- End diff --
Because consistency is a good thing :-) There are some tests named "JunitXXX" and some "JUnitXXX". It's better to have only one naming convention.
Yes I've searched the whole project for occurrences of "concurrentjunit47".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #125: Consistently rename JUnit 4.x integration tests
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/125
@britter
It makes me a problem to merge this PR. Please open a new one with same changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #125: Consistently rename JUnit 4.x integration ...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/125#discussion_r81666066
--- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/JUnit47ConcurrencyIT.java ---
@@ -32,14 +32,14 @@
*
* @author Kristian Rosenvold
*/
-public class Junit47concurrencyIT
--- End diff --
Why changing these names is important? Are you sure you have changed all occurencies of folder `concurrentjunit47`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #125: Consistently rename JUnit 4.x integration tests
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/125
@britter
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #125: Consistently rename JUnit 4.x integration ...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/125#discussion_r82520806
--- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/JUnit47ConcurrencyIT.java ---
@@ -32,14 +32,14 @@
*
* @author Kristian Rosenvold
*/
-public class Junit47concurrencyIT
--- End diff --
@Tibor17 you don't like this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #125: Consistently rename JUnit 4.x integration ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/maven-surefire/pull/125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org