[GitHub] [spark] zero323 commented on a diff in pull request #38037: [SPARK-40537][CONNECT] Enable mypy for Spark Connect Python Client

[GitBox <gi...@apache.org>]

zero323 commented on code in PR #38037:
URL: https://github.com/apache/spark/pull/38037#discussion_r985130094


##########
python/pyspark/sql/connect/typing/__init__.pyi:
##########
@@ -0,0 +1,87 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+from typing import Callable, Union
+from pyspark.sql.connect.column import ExpressionOrString, ScalarFunctionExpression, ColumnOrString
+from pyspark.sql.connect.function_builder import UserDefinedFunction
+
+FunctionBuilderCallables = Union[

Review Comment:
   As long as we don't care about specific arity, we should be able to replace this with
   
   ```python
   class FunctionBuilderCallables(Protocol):
       def __call__(self, *exprs: ExpressionOrString) -> ScalarFunctionExpression: ...
   ```
   
   I'd also keep the name singular\.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org