You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2017/08/13 02:18:49 UTC
[GitHub] spark pull request #18930: [SPARK-21677][SQL] json_tuple throws NullPointExc...
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r132830750
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala ---
@@ -361,10 +361,18 @@ case class JsonTuple(children: Seq[Expression])
// the fields to query are the remaining children
@transient private lazy val fieldExpressions: Seq[Expression] = children.tail
+ // toString on null will throw NullPointerException so that return a very unlikely column name
+ private val nullFieldName = "__NullFieldName"
--- End diff --
`A field name given with constant null will be replaced with this pseudo field name. `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org