You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by md...@apache.org on 2009/07/08 13:28:04 UTC
svn commit: r792102 -
/jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java
Author: mduerig
Date: Wed Jul 8 11:28:03 2009
New Revision: 792102
URL: http://svn.apache.org/viewvc?rev=792102&view=rev
Log:
JCR-2194: EventImpl should implement toString
Modified:
jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java
Modified: jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java?rev=792102&r1=792101&r2=792102&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java (original)
+++ jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java Wed Jul 8 11:28:03 2009
@@ -181,4 +181,19 @@
return timestamp;
}
}
+
+ public String toString() {
+ return new StringBuffer(getClass().getName())
+ .append("[")
+ .append("eventTypes: ").append(type).append(", ")
+ .append("absPath: ").append(path).append(", ")
+ .append("itemId: ").append(itemId).append(", ")
+ .append("parentId: ").append(parentId).append(", ")
+ .append("primaryNodeTypeName: ").append(primaryNodeTypeName).append(", ")
+ .append("mixinTypeNames: ").append(mixinTypeNames).append(", ")
+ .append("userId").append(userId)
+ .append("]")
+ .toString();
+ }
+
}
Re: svn commit: r792102 - /jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java
Posted by Marcel Reutegger <ma...@gmx.net>.
On Wed, Jul 8, 2009 at 14:14, Jukka Zitting<ju...@gmail.com> wrote:
> Or simply use the + operator which makes the code less verbose (and
> automatically uses StringBuilder when compiled for Java 5).
hmm, good point to leave it up to the compiler, though it doesn't have
to be StringBuilder... [0]
regards
marcel
[0] http://java.sun.com/docs/books/jls/third_edition/html/expressions.html#15.18.1.2
Re: svn commit: r792102 - /jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java
Posted by Jukka Zitting <ju...@gmail.com>.
Hi,
On Wed, Jul 8, 2009 at 2:01 PM, Marcel
Reutegger<ma...@day.com> wrote:
> not really criticizing this particular commit since I already reviewed
> it and said it looks good ;) but I just noticed that we should now
> rather use StringBuilder (available in Java 5) instead of synchronized
> StringBuffer.
Or simply use the + operator which makes the code less verbose (and
automatically uses StringBuilder when compiled for Java 5).
BR,
Jukka Zitting
Re: svn commit: r792102 - /jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java
Posted by Marcel Reutegger <ma...@day.com>.
not really criticizing this particular commit since I already reviewed
it and said it looks good ;) but I just noticed that we should now
rather use StringBuilder (available in Java 5) instead of synchronized
StringBuffer. This is similar to using ArrayList when possible rather
than Vector...
regards
marcel
On Wed, Jul 8, 2009 at 13:28, <md...@apache.org> wrote:
> Author: mduerig
> Date: Wed Jul 8 11:28:03 2009
> New Revision: 792102
>
> URL: http://svn.apache.org/viewvc?rev=792102&view=rev
> Log:
> JCR-2194: EventImpl should implement toString
>
> Modified:
> jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java
>
> Modified: jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java
> URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java?rev=792102&r1=792101&r2=792102&view=diff
> ==============================================================================
> --- jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java (original)
> +++ jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/EventImpl.java Wed Jul 8 11:28:03 2009
> @@ -181,4 +181,19 @@
> return timestamp;
> }
> }
> +
> + public String toString() {
> + return new StringBuffer(getClass().getName())
> + .append("[")
> + .append("eventTypes: ").append(type).append(", ")
> + .append("absPath: ").append(path).append(", ")
> + .append("itemId: ").append(itemId).append(", ")
> + .append("parentId: ").append(parentId).append(", ")
> + .append("primaryNodeTypeName: ").append(primaryNodeTypeName).append(", ")
> + .append("mixinTypeNames: ").append(mixinTypeNames).append(", ")
> + .append("userId").append(userId)
> + .append("]")
> + .toString();
> + }
> +
> }
>
>
>