[jira] [Commented] (ZOOKEEPER-827) enable r/o mode in C client library

["Chris Nauroth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525469#comment-14525469 ] 

Chris Nauroth commented on ZOOKEEPER-827:
-----------------------------------------

This patch accidentally introduced a compilation failure on Windows, where {{socket_t}} is defined to be a Windows {{SOCKET}}, not an {{int}}.  Therefore, the return types differ between the function declaration and definition:

{code}
static int zookeeper_connect(zhandle_t *, struct sockaddr_storage *, socket_t);
...
static socket_t zookeeper_connect(zhandle_t *zh,
                                  struct sockaddr_storage *addr,
                                  socket_t fd)
{code}

I filed a patch on ZOOKEEPER-2178 to fix this and a few other Windows issues.


> enable r/o mode in C client library
> -----------------------------------
>
>                 Key: ZOOKEEPER-827
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-827
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Sergey Doroshenko
>            Assignee: Raul Gutierrez Segales
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-827.patch, ZOOKEEPER-827.patch, ZOOKEEPER-827.patch, ZOOKEEPER-827.patch, ZOOKEEPER-827.patch, ZOOKEEPER-827.patch, ZOOKEEPER-827.patch, ZOOKEEPER-827.patch, ZOOKEEPER-827.patch, ZOOKEEPER-827.patch
>
>
> Implement read-only mode functionality (in accordance with http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode) in C client library



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)