You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/07/25 00:06:08 UTC

[GitHub] [helix] zhangmeng916 opened a new pull request #1172: add tutorial for Helix cloud support

zhangmeng916 opened a new pull request #1172:
URL: https://github.com/apache/helix/pull/1172

### Issues

- [ ] My PR addresses the following Helix issues and references them in the PR description:

Fixes #1145

### Description

- [X] Here are some details about my PR, including screenshots of any UI changes:

This PR adds tutorial on how to use Helix cloud support. Specifically, it guides user through the steps to realized participant auto registration to a cluster.

### Tests

- [X] The following is the result of the "mvn test" command on the appropriate module:

mvn site:site
mvn site:stage
passed
Generated webpage is checked.

### Commits

- [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"

### Code Quality

- [X] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] pkuwm commented on pull request #1172: add tutorial for Helix cloud support

Posted by GitBox <gi...@apache.org>.

pkuwm commented on pull request #1172:
URL: https://github.com/apache/helix/pull/1172#issuecomment-663944776


   @zhangmeng916 Good doc! I would suggest using google docs or office to do spell check if not yet. It may help polish the doc. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] dasahcc merged pull request #1172: add tutorial for Helix cloud support

Posted by GitBox <gi...@apache.org>.

dasahcc merged pull request #1172:
URL: https://github.com/apache/helix/pull/1172


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] zhangmeng916 commented on pull request #1172: add tutorial for Helix cloud support

Posted by GitBox <gi...@apache.org>.

zhangmeng916 commented on pull request #1172:
URL: https://github.com/apache/helix/pull/1172#issuecomment-664004262


   This PR is read to be merged. Approved by @pkuwm 
   Final commit message:
   Add tutorial for how to use cloud support in Helix for participant auto registration.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org