[GitHub] [incubator-druid] leventov commented on a change in pull request #8272: Support incremental load in Druid lookups

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #8272: Support incremental load in Druid lookups
URL: https://github.com/apache/incubator-druid/pull/8272#discussion_r313489533
 
 

 ##########
 File path: extensions-core/lookups-cached-global/src/main/java/org/apache/druid/server/lookup/namespace/JdbcCacheGenerator.java
 ##########
 @@ -148,6 +174,32 @@ private String buildLookupQuery(String table, String filter, String keyColumn, S
     );
   }
 
+  private String buildIncrementalLookupQuery(String table, String filter, String keyColumn, String valueColumn, String tsColumn, Long lastLoadTs)
 
 Review comment:
   `lastLoadTs` doesn't need to be boxed `Long`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org