You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry via Review Board <no...@reviews.apache.org> on 2021/09/21 15:40:15 UTC
Re: Review Request 73589: Indexing Monitor and Recovery
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73589/
-----------------------------------------------------------
(Updated Sept. 21, 2021, 3:40 p.m.)
Review request for atlas, Nikhil Bonte, Nixon Rodrigues, Radhika Kundam, and Sarath Subramanian.
Changes
-------
Updates include:
- Addressed review comments.
- Added description.
Summary (updated)
-----------------
Indexing Monitor and Recovery
Bugs: ATLAS-4408
https://issues.apache.org/jira/browse/ATLAS-4408
Repository: atlas
Description (updated)
-------
This implementation builds up on Radhika's earlier implementation. https://reviews.apache.org/r/73555/
Indexing
atlas.graph.index.status.check.frequency: Frequence of checking Solr for health status.
atlas.graph.index.recovery.start.time: User can set recovery time in UTC. E.g.
```
atlas.graph.index.recovery.start.time=2014-12-11T02:35:58.440Z
```
**Implementation**
New: _updateGlobalConfiguration_: Updating global configuration variables.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java aea0c1311
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndexClient.java 9960d8909
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 7e3b2f440
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 11267c438
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java ef42dbd3d
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java 1cc7f8b55
intg/src/main/java/org/apache/atlas/ApplicationProperties.java 682206dad
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java ddfb0089e
repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/RecoveryInfoManagementTest.java PRE-CREATION
server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java ba8f0886c
Diff: https://reviews.apache.org/r/73589/diff/2/
Changes: https://reviews.apache.org/r/73589/diff/1-2/
Testing (updated)
-------
Additional unit tests.
Thanks,
Ashutosh Mestry
Re: Review Request 73589: Indexing Monitor and Recovery
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
> On Sept. 21, 2021, 7:35 p.m., Sarath Subramanian wrote:
> > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
> > Lines 215 (patched)
> > <https://reviews.apache.org/r/73589/diff/1/?file=2252880#file2252880line217>
> >
> > in that case - only if user explicitly sets the config in atlas application properties to true/false we should change the global config.
> >
> > It takes a default value here and always updates the global config even if user haven't set it.
> >
> > global config is a site-wide setting for Atlas/Janusgraph and should not be changed unless explicitly specified.
E.g.: User sets the config then removes it. Unless we maintain a state across restarts, we won't know.
Another option is to read existing value and match it against incoming and update it only if there is a change.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73589/#review223508
-----------------------------------------------------------
On Sept. 21, 2021, 3:40 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73589/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2021, 3:40 p.m.)
>
>
> Review request for atlas, Nikhil Bonte, Nixon Rodrigues, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4408
> https://issues.apache.org/jira/browse/ATLAS-4408
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This implementation builds up on Radhika's earlier implementation. https://reviews.apache.org/r/73555/
>
> Indexing
>
> atlas.graph.index.status.check.frequency: Frequence of checking Solr for health status.
> atlas.graph.index.recovery.start.time: User can set recovery time in UTC. E.g.
> ```
> atlas.graph.index.recovery.start.time=2014-12-11T02:35:58.440Z
> ```
>
> **Implementation**
> New: _updateGlobalConfiguration_: Updating global configuration variables.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java aea0c1311
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndexClient.java 9960d8909
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 7e3b2f440
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 11267c438
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java ef42dbd3d
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java 1cc7f8b55
> intg/src/main/java/org/apache/atlas/ApplicationProperties.java 682206dad
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java ddfb0089e
> repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/graph/RecoveryInfoManagementTest.java PRE-CREATION
> server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java ba8f0886c
>
>
> Diff: https://reviews.apache.org/r/73589/diff/2/
>
>
> Testing
> -------
>
> Additional unit tests.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 73589: Indexing Monitor and Recovery
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73589/#review223508
-----------------------------------------------------------
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
Lines 215 (patched)
<https://reviews.apache.org/r/73589/#comment312588>
in that case - only if user explicitly sets the config in atlas application properties to true/false we should change the global config.
It takes a default value here and always updates the global config even if user haven't set it.
global config is a site-wide setting for Atlas/Janusgraph and should not be changed unless explicitly specified.
- Sarath Subramanian
On Sept. 21, 2021, 8:40 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73589/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2021, 8:40 a.m.)
>
>
> Review request for atlas, Nikhil Bonte, Nixon Rodrigues, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4408
> https://issues.apache.org/jira/browse/ATLAS-4408
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This implementation builds up on Radhika's earlier implementation. https://reviews.apache.org/r/73555/
>
> Indexing
>
> atlas.graph.index.status.check.frequency: Frequence of checking Solr for health status.
> atlas.graph.index.recovery.start.time: User can set recovery time in UTC. E.g.
> ```
> atlas.graph.index.recovery.start.time=2014-12-11T02:35:58.440Z
> ```
>
> **Implementation**
> New: _updateGlobalConfiguration_: Updating global configuration variables.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java aea0c1311
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndexClient.java 9960d8909
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 7e3b2f440
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 11267c438
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java ef42dbd3d
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java 1cc7f8b55
> intg/src/main/java/org/apache/atlas/ApplicationProperties.java 682206dad
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java ddfb0089e
> repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/graph/RecoveryInfoManagementTest.java PRE-CREATION
> server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java ba8f0886c
>
>
> Diff: https://reviews.apache.org/r/73589/diff/2/
>
>
> Testing
> -------
>
> Additional unit tests.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 73589: Indexing Monitor and Recovery
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73589/#review223594
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Sept. 21, 2021, 8:40 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73589/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2021, 8:40 a.m.)
>
>
> Review request for atlas, Nikhil Bonte, Nixon Rodrigues, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4408
> https://issues.apache.org/jira/browse/ATLAS-4408
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This implementation builds up on Radhika's earlier implementation. https://reviews.apache.org/r/73555/
>
> Indexing
>
> atlas.graph.index.status.check.frequency: Frequence of checking Solr for health status.
> atlas.graph.index.recovery.start.time: User can set recovery time in UTC. E.g.
> ```
> atlas.graph.index.recovery.start.time=2014-12-11T02:35:58.440Z
> ```
>
> **Implementation**
> New: _updateGlobalConfiguration_: Updating global configuration variables.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java aea0c1311
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndexClient.java 9960d8909
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 7e3b2f440
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 11267c438
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java ef42dbd3d
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java 1cc7f8b55
> intg/src/main/java/org/apache/atlas/ApplicationProperties.java 682206dad
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java ddfb0089e
> repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/graph/RecoveryInfoManagementTest.java PRE-CREATION
> server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java ba8f0886c
>
>
> Diff: https://reviews.apache.org/r/73589/diff/2/
>
>
> Testing
> -------
>
> Additional unit tests.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>