You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by jo...@apache.org on 2019/03/19 20:45:27 UTC
[impala] branch master updated (9090fc2 -> 4743f5e)
This is an automated email from the ASF dual-hosted git repository.
joemcdonnell pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git.
from 9090fc2 IMPALA-8097: mt_dop for all queries via hidden flag
new 2014199 IMPALA-8316. Update re2 to the latest version
new d3428a5 Revert "IMPALA-5393. Use THREAD_LOCAL state for regexp"
new 4743f5e Revert "IMPALA-8316. Update re2 to the latest version"
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
be/src/exprs/string-functions-ir.cc | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
[impala] 01/03: IMPALA-8316. Update re2 to the latest version
Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 2014199c80c6c74ba4e46139337cd41e1089cc9e
Author: Todd Lipcon <to...@apache.org>
AuthorDate: Mon Mar 18 10:09:11 2019 -0700
IMPALA-8316. Update re2 to the latest version
This updates re2 to the latest tagged release from github.
I benchmarked this with a simple query:
select sum(l_linenumber) from item_20x where length(regexp_extract(l_shipinstruct, '.*', 0)) > 0
Prior to the change:
- TotalCpuTime: 42s848ms
- wall time: ~19sec
With the change:
- TotalCpuTime: 33s634ms
- wall time: 14-15sec
Change-Id: Id41ca642f5f48fd6237e13f7cab0445e0a402816
Reviewed-on: http://gerrit.cloudera.org:8080/12778
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
bin/impala-config.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bin/impala-config.sh b/bin/impala-config.sh
index 01bd918..2686fd3 100755
--- a/bin/impala-config.sh
+++ b/bin/impala-config.sh
@@ -68,7 +68,7 @@ fi
# moving to a different build of the toolchain, e.g. when a version is bumped or a
# compile option is changed. The build id can be found in the output of the toolchain
# build jobs, it is constructed from the build number and toolchain git hash prefix.
-export IMPALA_TOOLCHAIN_BUILD_ID=43961c5c-7ece-489c-a6e3-ec4cbe7ef4b5-b23c19a002
+export IMPALA_TOOLCHAIN_BUILD_ID=255-58192fb6bc
# Versions of toolchain dependencies.
# -----------------------------------
export IMPALA_AVRO_VERSION=1.7.4-p4
@@ -130,7 +130,7 @@ export IMPALA_POSTGRES_JDBC_DRIVER_VERSION=9.0-801
unset IMPALA_POSTGRES_JDBC_DRIVER_URL
export IMPALA_RAPIDJSON_VERSION=1.1.0
unset IMPALA_RAPIDJSON_URL
-export IMPALA_RE2_VERSION=20130115-p1
+export IMPALA_RE2_VERSION=20190301
unset IMPALA_RE2_URL
export IMPALA_SNAPPY_VERSION=1.1.4
unset IMPALA_SNAPPY_URL
[impala] 02/03: Revert "IMPALA-5393. Use THREAD_LOCAL state for
regexp"
Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit d3428a58d8f54d1a64d5aeb1af3f76b7ffcb53d0
Author: Lars Volker <lv...@cloudera.com>
AuthorDate: Tue Mar 19 14:52:20 2019 +0000
Revert "IMPALA-5393. Use THREAD_LOCAL state for regexp"
This depends on a change which switches to a toolchain version that does not have packages for Ubuntu 18.04. Reverting both now to unblock everyone.
This reverts commit 6e8c330f40da087ca0d8ba844cd9d97a8e60ff67.
Change-Id: Id35a90a58e3f775031a0f147b042ccd46d77e24b
Reviewed-on: http://gerrit.cloudera.org:8080/12791
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Lars Volker <lv...@cloudera.com>
---
be/src/exprs/string-functions-ir.cc | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/be/src/exprs/string-functions-ir.cc b/be/src/exprs/string-functions-ir.cc
index 67b7ce1..a4d4962 100644
--- a/be/src/exprs/string-functions-ir.cc
+++ b/be/src/exprs/string-functions-ir.cc
@@ -664,7 +664,7 @@ bool StringFunctions::SetRE2Options(const StringVal& match_parameter,
void StringFunctions::RegexpPrepare(
FunctionContext* context, FunctionContext::FunctionStateScope scope) {
- if (scope != FunctionContext::THREAD_LOCAL) return;
+ if (scope != FunctionContext::FRAGMENT_LOCAL) return;
if (!context->IsArgConstant(1)) return;
DCHECK_EQ(context->GetArgType(1)->type, FunctionContext::TYPE_STRING);
StringVal* pattern = reinterpret_cast<StringVal*>(context->GetConstantArg(1));
@@ -681,7 +681,7 @@ void StringFunctions::RegexpPrepare(
void StringFunctions::RegexpClose(
FunctionContext* context, FunctionContext::FunctionStateScope scope) {
- if (scope != FunctionContext::THREAD_LOCAL) return;
+ if (scope != FunctionContext::FRAGMENT_LOCAL) return;
re2::RE2* re = reinterpret_cast<re2::RE2*>(context->GetFunctionState(scope));
delete re;
context->SetFunctionState(scope, nullptr);
@@ -715,7 +715,7 @@ StringVal StringFunctions::RegexpExtract(FunctionContext* context, const StringV
if (index.val < 0) return StringVal();
re2::RE2* re = reinterpret_cast<re2::RE2*>(
- context->GetFunctionState(FunctionContext::THREAD_LOCAL));
+ context->GetFunctionState(FunctionContext::FRAGMENT_LOCAL));
scoped_ptr<re2::RE2> scoped_re; // destroys re if we have to locally compile it
if (re == NULL) {
DCHECK(!context->IsArgConstant(1));
@@ -747,7 +747,7 @@ StringVal StringFunctions::RegexpReplace(FunctionContext* context, const StringV
if (str.is_null || pattern.is_null || replace.is_null) return StringVal::null();
re2::RE2* re = reinterpret_cast<re2::RE2*>(
- context->GetFunctionState(FunctionContext::THREAD_LOCAL));
+ context->GetFunctionState(FunctionContext::FRAGMENT_LOCAL));
scoped_ptr<re2::RE2> scoped_re; // destroys re if state->re is NULL
if (re == NULL) {
DCHECK(!context->IsArgConstant(1));
@@ -769,7 +769,7 @@ StringVal StringFunctions::RegexpReplace(FunctionContext* context, const StringV
void StringFunctions::RegexpMatchCountPrepare(FunctionContext* context,
FunctionContext::FunctionStateScope scope) {
- if (scope != FunctionContext::THREAD_LOCAL) return;
+ if (scope != FunctionContext::FRAGMENT_LOCAL) return;
int num_args = context->GetNumArgs();
DCHECK(num_args == 2 || num_args == 4);
if (!context->IsArgConstant(1) || (num_args == 4 && !context->IsArgConstant(3))) return;
@@ -816,7 +816,7 @@ IntVal StringFunctions::RegexpMatchCount4Args(FunctionContext* context,
}
re2::RE2* re = reinterpret_cast<re2::RE2*>(
- context->GetFunctionState(FunctionContext::THREAD_LOCAL));
+ context->GetFunctionState(FunctionContext::FRAGMENT_LOCAL));
// Destroys re if we have to locally compile it.
scoped_ptr<re2::RE2> scoped_re;
if (re == NULL) {
[impala] 03/03: Revert "IMPALA-8316. Update re2 to the latest
version"
Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 4743f5edb93905d9feff2b5db5b6e4741c972449
Author: Lars Volker <lv...@cloudera.com>
AuthorDate: Tue Mar 19 14:50:31 2019 +0000
Revert "IMPALA-8316. Update re2 to the latest version"
This uses a toolchain version that depends on Ubuntu 18.04. We'll have to re-submit once the toolchain has been published for that OS, too.
This reverts commit 2014199c80c6c74ba4e46139337cd41e1089cc9e.
Change-Id: I4fd16048cf5d89d76bc00ca2837cb11829e30192
Reviewed-on: http://gerrit.cloudera.org:8080/12790
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Lars Volker <lv...@cloudera.com>
---
bin/impala-config.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bin/impala-config.sh b/bin/impala-config.sh
index 2686fd3..01bd918 100755
--- a/bin/impala-config.sh
+++ b/bin/impala-config.sh
@@ -68,7 +68,7 @@ fi
# moving to a different build of the toolchain, e.g. when a version is bumped or a
# compile option is changed. The build id can be found in the output of the toolchain
# build jobs, it is constructed from the build number and toolchain git hash prefix.
-export IMPALA_TOOLCHAIN_BUILD_ID=255-58192fb6bc
+export IMPALA_TOOLCHAIN_BUILD_ID=43961c5c-7ece-489c-a6e3-ec4cbe7ef4b5-b23c19a002
# Versions of toolchain dependencies.
# -----------------------------------
export IMPALA_AVRO_VERSION=1.7.4-p4
@@ -130,7 +130,7 @@ export IMPALA_POSTGRES_JDBC_DRIVER_VERSION=9.0-801
unset IMPALA_POSTGRES_JDBC_DRIVER_URL
export IMPALA_RAPIDJSON_VERSION=1.1.0
unset IMPALA_RAPIDJSON_URL
-export IMPALA_RE2_VERSION=20190301
+export IMPALA_RE2_VERSION=20130115-p1
unset IMPALA_RE2_URL
export IMPALA_SNAPPY_VERSION=1.1.4
unset IMPALA_SNAPPY_URL