You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/02/16 18:55:34 UTC
Re: Review Request 42696: Speed up FetcherCacheTest.Local* test by
reduce loop.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/
-----------------------------------------------------------
(Updated Feb. 16, 2016, 5:55 p.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd Mathiske.
Changes
-------
Rebase
Summary (updated)
-----------------
Speed up FetcherCacheTest.Local* test by reduce loop.
Bugs: MESOS-4486
https://issues.apache.org/jira/browse/MESOS-4486
Repository: mesos
Description (updated)
-------
Speed up FetcherCacheTest.Local* test by reduce loop.
Diffs (updated)
-----
src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
Diff: https://reviews.apache.org/r/42696/diff/
Testing (updated)
-------
Before
```
[ OK ] FetcherCacheTest.LocalUncached (2580 ms)
[ OK ] FetcherCacheTest.LocalCached (2516 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (2594 ms)
```
After
```
[ OK ] FetcherCacheTest.LocalUncached (977 ms)
[ OK ] FetcherCacheTest.LocalCached (1731 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (975 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1713 ms)
```
Thanks,
haosdent huang
Re: Review Request 42696: Speed up FetcherCacheTest.Local* test by
reduce loop.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119427
-----------------------------------------------------------
Ship it!
Now without the checkpointing-related code which went into a separate review, let's ship it!
- Bernd Mathiske
On Feb. 16, 2016, 6:10 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2016, 6:10 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd Mathiske.
>
>
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up FetcherCacheTest.Local* test by reduce loop.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f
>
> Diff: https://reviews.apache.org/r/42696/diff/
>
>
> Testing
> -------
>
> Before
> ```
> [ OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [ OK ] FetcherCacheTest.LocalCached (2516 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (2594 ms)
> ```
>
> After
> ```
> [ OK ] FetcherCacheTest.LocalUncached (977 ms)
> [ OK ] FetcherCacheTest.LocalCached (1731 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (975 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1713 ms)
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42696: Speed up FetcherCacheTest.Local* test by
reduce loop.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/
-----------------------------------------------------------
(Updated Feb. 17, 2016, 2:10 a.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd Mathiske.
Changes
-------
Rebase
Bugs: MESOS-4486
https://issues.apache.org/jira/browse/MESOS-4486
Repository: mesos
Description
-------
Speed up FetcherCacheTest.Local* test by reduce loop.
Diffs (updated)
-----
src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f
Diff: https://reviews.apache.org/r/42696/diff/
Testing
-------
Before
```
[ OK ] FetcherCacheTest.LocalUncached (2580 ms)
[ OK ] FetcherCacheTest.LocalCached (2516 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (2594 ms)
```
After
```
[ OK ] FetcherCacheTest.LocalUncached (977 ms)
[ OK ] FetcherCacheTest.LocalCached (1731 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (975 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1713 ms)
```
Thanks,
haosdent huang