[jira] [Commented] (OOZIE-2706) OYA: Shell action improvements

["Peter Bacsko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-2706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010558#comment-16010558 ] 

Peter Bacsko commented on OOZIE-2706:
-------------------------------------

This is done

> OYA: Shell action improvements
> ------------------------------
>
>                 Key: OOZIE-2706
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2706
>             Project: Oozie
>          Issue Type: Sub-task
>            Reporter: Peter Cseh
>
> We had some review requests for OOZIE-2598. We should address them.
> {quote}
> You catch 3 kind of exceptions, and rethrow it with the same message. Can you change the messages to capture the original type instead of the generic "Exception".
> If we do not need to mention the exact reason in the exception (for example because it is later handled) in MapReduceMain.runConfigClass(), you an use a multicatch. If we need to know, what caused the problem, we can indicate exception type (based on e.getClass().getCanonicalName()) for example, in a log message as well.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)