You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Francois Papon <fr...@openobject.fr> on 2020/04/16 12:59:42 UTC

MetricRegistry impl

Hi,

I pushed a PR to override the default methods of the MetricRegistry implementation.
The default methods will be removed from the specs in the next release.

https://github.com/apache/geronimo-metrics/pull/5

Here the jira:

https://issues.apache.org/jira/browse/GERONIMO-6769

Thoughts?

regards,

-- 
François
fpapon@apache.org


Re: MetricRegistry impl

Posted by Romain Manni-Bucau <rm...@gmail.com>.
Looks good, will review and merge it this afternoon.

Thanks a lot François!

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le jeu. 16 avr. 2020 à 14:59, Francois Papon <fr...@openobject.fr>
a écrit :

> Hi,
>
> I pushed a PR to override the default methods of the MetricRegistry implementation.
> The default methods will be removed from the specs in the next release.
> https://github.com/apache/geronimo-metrics/pull/5
>
> Here the jira:
> https://issues.apache.org/jira/browse/GERONIMO-6769
>
> Thoughts?
>
> regards,
>
> --
> Françoisfpapon@apache.org
>
>

Re: MetricRegistry impl

Posted by Jean-Baptiste Onofre <jb...@nanthrax.net>.
It sounds good, thanks !

Regards
JB

> Le 16 avr. 2020 à 14:59, Francois Papon <fr...@openobject.fr> a écrit :
> 
> Hi,
> 
> I pushed a PR to override the default methods of the MetricRegistry implementation.
> The default methods will be removed from the specs in the next release.
> 
> https://github.com/apache/geronimo-metrics/pull/5 <https://github.com/apache/geronimo-metrics/pull/5>
> 
> Here the jira:
> 
> https://issues.apache.org/jira/browse/GERONIMO-6769 <https://issues.apache.org/jira/browse/GERONIMO-6769>
> 
> Thoughts?
> 
> regards,
> -- 
> François
> fpapon@apache.org <ma...@apache.org>