[jira] [Commented] (OAK-7158) Users shouldn't be able to change the number of retained generations

["Francesco Mari (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-7158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327120#comment-16327120 ] 

Francesco Mari commented on OAK-7158:
-------------------------------------

Backport to 1.8 at r1821244.

> Users shouldn't be able to change the number of retained generations
> --------------------------------------------------------------------
>
>                 Key: OAK-7158
>                 URL: https://issues.apache.org/jira/browse/OAK-7158
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>            Priority: Major
>              Labels: candidate_oak_1_8
>             Fix For: 1.9.0, 1.10
>
>         Attachments: OAK-7158-01.diff, OAK-7158-02.diff, OAK-7158-03.diff
>
>
> Currently, {{SegmentGCOptions}} implements a validation check on the number of retained generations that prevents callers to set it to a value smaller than two. Instead, some subsystems might benefit from having a number of retained generations smaller than two - see OAK-7157 as an example.
> The check performed by {{SegmentGCOptions}} should be moved to {{SegmentNodeStoreService}} to prevent users from setting the number of retained generations to a an invalid value. Internal subsystems should be allowed to set the number of retained generations to a lower value, if needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)