You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/07/29 11:01:50 UTC
Review Request 36904: LENS-320: Lombok Javadoc issue
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36904/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-320
https://issues.apache.org/jira/browse/LENS-320
Repository: lens
Description
-------
Javadoc for classes annotated with Lombok's annotations is not showing properly
Example - http://lens.incubator.apache.org/apidocs/org/apache/lens/api/APIResult.html
APIResult's javadoc is not showing accessor methods.
Diffs
-----
pom.xml b395658683482ee44b289e445d33ff1555060a37
src/site/apt/user/cli.apt a28d8a49bdcc171b889ba125e0de041010b989d3
tools/scripts/generate-site-public.sh 0f2e45c8bfbf92dd3134ec1891be23fb50cc3256
Diff: https://reviews.apache.org/r/36904/diff/
Testing
-------
http://postimg.org/image/b99badf3z/
Thanks,
Rajat Khandelwal
Re: Review Request 36904: LENS-320: Lombok Javadoc issue
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On July 29, 2015, 2:39 p.m., Amareshwari Sriramadasu wrote:
> > I hope other javadoc (non lombok java code) is fine.
This is a diff(text diff in htmls): https://github.com/prongs/lens-site/compare/without_delombok1...with_delombok2
non lombok code is as it is. It `delombok`s all files, the files that don't use `lombok`, are converted to the same file.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36904/#review93415
-----------------------------------------------------------
On July 29, 2015, 2:31 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36904/
> -----------------------------------------------------------
>
> (Updated July 29, 2015, 2:31 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-320
> https://issues.apache.org/jira/browse/LENS-320
>
>
> Repository: lens
>
>
> Description
> -------
>
> Javadoc for classes annotated with Lombok's annotations is not showing properly
>
> Example - http://lens.incubator.apache.org/apidocs/org/apache/lens/api/APIResult.html
>
> APIResult's javadoc is not showing accessor methods.
>
>
> Diffs
> -----
>
> pom.xml b395658683482ee44b289e445d33ff1555060a37
> src/site/apt/user/cli.apt a28d8a49bdcc171b889ba125e0de041010b989d3
> tools/scripts/generate-site-public.sh 0f2e45c8bfbf92dd3134ec1891be23fb50cc3256
>
> Diff: https://reviews.apache.org/r/36904/diff/
>
>
> Testing
> -------
>
> http://postimg.org/image/b99badf3z/
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 36904: LENS-320: Lombok Javadoc issue
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36904/#review93415
-----------------------------------------------------------
Ship it!
I hope other javadoc (non lombok java code) is fine.
- Amareshwari Sriramadasu
On July 29, 2015, 9:01 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36904/
> -----------------------------------------------------------
>
> (Updated July 29, 2015, 9:01 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-320
> https://issues.apache.org/jira/browse/LENS-320
>
>
> Repository: lens
>
>
> Description
> -------
>
> Javadoc for classes annotated with Lombok's annotations is not showing properly
>
> Example - http://lens.incubator.apache.org/apidocs/org/apache/lens/api/APIResult.html
>
> APIResult's javadoc is not showing accessor methods.
>
>
> Diffs
> -----
>
> pom.xml b395658683482ee44b289e445d33ff1555060a37
> src/site/apt/user/cli.apt a28d8a49bdcc171b889ba125e0de041010b989d3
> tools/scripts/generate-site-public.sh 0f2e45c8bfbf92dd3134ec1891be23fb50cc3256
>
> Diff: https://reviews.apache.org/r/36904/diff/
>
>
> Testing
> -------
>
> http://postimg.org/image/b99badf3z/
>
>
> Thanks,
>
> Rajat Khandelwal
>
>