You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/11/03 03:47:43 UTC
Re: Review Request 27330: SQOOP-1510:JobRequestHandler for
submit/abort job and SubmissionHandler changes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------
(Updated Nov. 2, 2014, 6:47 p.m.)
Review request for Sqoop.
Changes
-------
Rebased to latest as of 6.47 Nov 2
Repository: sqoop-sqoop2
Description
-------
see JIRA and its parent JIRA for details
FYI : it does nto include the start/submit and stop/abort renames.
new tickets have been added to address these
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c
client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a
client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3
client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7
client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783
common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591
common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338
common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5
common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd
common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf
core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282
core/src/main/java/org/apache/sqoop/driver/JobManager.java ba56c77
core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 976223d
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1e22759
core/src/main/java/org/apache/sqoop/repository/Repository.java 09989e0
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b324f4f
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 35a9635
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c
server/src/main/java/org/apache/sqoop/server/RequestHandler.java 508edd2
server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237
server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883
server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml 6ad90d2
shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965
shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05
shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87
shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3
shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522
shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 176833a
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 06462a3
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68
Diff: https://reviews.apache.org/r/27330/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27330: SQOOP-1510:JobRequestHandler for
submit/abort job and SubmissionHandler changes
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59719
-----------------------------------------------------------
shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java
<https://reviews.apache.org/r/27330/#comment101032>
yes good catch
- Veena Basavaraj
On Nov. 3, 2014, 9:25 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 9:25 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA and its parent JIRA for details
>
> FYI : it does nto include the start/submit and stop/abort renames.
>
> new tickets have been added to address these
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c
> client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a
> client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7
> client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783
> common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591
> common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338
> common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5
> common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd
> common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf
> core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282
> core/src/main/java/org/apache/sqoop/driver/JobManager.java ba56c77
> core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 976223d
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1e22759
> core/src/main/java/org/apache/sqoop/repository/Repository.java 61d6b9b
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b324f4f
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c
> server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237
> server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883
> server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml 6ad90d2
> shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965
> shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05
> shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87
> shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3
> shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522
> shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7
> shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 60f9500
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 06462a3
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68
>
> Diff: https://reviews.apache.org/r/27330/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27330: SQOOP-1510:JobRequestHandler for
submit/abort job and SubmissionHandler changes
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59730
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Nov. 3, 2014, 5:25 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 5:25 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA and its parent JIRA for details
>
> FYI : it does nto include the start/submit and stop/abort renames.
>
> new tickets have been added to address these
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c
> client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a
> client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7
> client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783
> common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591
> common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338
> common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5
> common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd
> common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf
> core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282
> core/src/main/java/org/apache/sqoop/driver/JobManager.java ba56c77
> core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 976223d
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1e22759
> core/src/main/java/org/apache/sqoop/repository/Repository.java 61d6b9b
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b324f4f
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c
> server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237
> server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883
> server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml 6ad90d2
> shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965
> shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05
> shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87
> shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3
> shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522
> shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7
> shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 60f9500
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 06462a3
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68
>
> Diff: https://reviews.apache.org/r/27330/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27330: SQOOP-1510:JobRequestHandler for
submit/abort job and SubmissionHandler changes
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/#review59557
-----------------------------------------------------------
Ship it!
Good stuff! One small issue, but +1!
shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java
<https://reviews.apache.org/r/27330/#comment100829>
Unintentional?
- Abraham Elmahrek
On Nov. 3, 2014, 5:25 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27330/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 5:25 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA and its parent JIRA for details
>
> FYI : it does nto include the start/submit and stop/abort renames.
>
> new tickets have been added to address these
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c
> client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a
> client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7
> client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783
> common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591
> common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338
> common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5
> common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd
> common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf
> core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282
> core/src/main/java/org/apache/sqoop/driver/JobManager.java ba56c77
> core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 976223d
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1e22759
> core/src/main/java/org/apache/sqoop/repository/Repository.java 61d6b9b
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b324f4f
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c
> server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237
> server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883
> server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml 6ad90d2
> shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965
> shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05
> shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87
> shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3
> shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522
> shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7
> shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 60f9500
> test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 06462a3
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68
>
> Diff: https://reviews.apache.org/r/27330/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27330: SQOOP-1510:JobRequestHandler for
submit/abort job and SubmissionHandler changes
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27330/
-----------------------------------------------------------
(Updated Nov. 3, 2014, 9:25 a.m.)
Review request for Sqoop.
Changes
-------
rebased as of 9.24 A.M nov 3rd
Repository: sqoop-sqoop2
Description
-------
see JIRA and its parent JIRA for details
FYI : it does nto include the start/submit and stop/abort renames.
new tickets have been added to address these
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java 33a0c3c
client/src/main/java/org/apache/sqoop/client/SubmissionCallback.java de7211a
client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 83c08b3
client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 4a56bb7
client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java 5055783
common/src/main/java/org/apache/sqoop/json/JobBean.java 082d591
common/src/main/java/org/apache/sqoop/json/JobsBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/JsonBean.java ba86511
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 4b80338
common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MSubmission.java 7290df5
common/src/test/java/org/apache/sqoop/json/TestJobBean.java 1fc8dbd
common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java e4d50bf
core/src/main/java/org/apache/sqoop/driver/DriverError.java ddee282
core/src/main/java/org/apache/sqoop/driver/JobManager.java ba56c77
core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 976223d
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1e22759
core/src/main/java/org/apache/sqoop/repository/Repository.java 61d6b9b
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b324f4f
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java c894d06
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 5547988
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 8555b0c
server/src/main/java/org/apache/sqoop/server/v1/JobServlet.java d295237
server/src/main/java/org/apache/sqoop/server/v1/JobsServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/SubmissionServlet.java 5c1d883
server/src/main/java/org/apache/sqoop/server/v1/SubmissionsServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml 6ad90d2
shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965
shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java 4363f05
shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 3447a87
shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java fb83af3
shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java 790c522
shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java dd075d7
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 60f9500
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 06462a3
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java 36f7443
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java c219e68
Diff: https://reviews.apache.org/r/27330/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj