You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/12/17 21:14:39 UTC

[GitHub] [thrift] elludraon opened a new pull request #2297: THRIFT-5325: Fix Lua library writeStructEnd() in TCompactProtocol

elludraon opened a new pull request #2297:
URL: https://github.com/apache/thrift/pull/2297


   In 0.13.0, two changes were made to the Lua library's TCompactProtocol for writing structs: THRIFT-4992 (writeStructEnd) and THRIFT-5262 (writeStructBegin). Unfortunately these addressed the same issue, so the two changes together just recreated the original problem of corrupt field indices in nested structs.
   
   Revert the change in THRIFT-4992 (and keep the one in THRIFT-5262).
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G closed pull request #2297: THRIFT-5325: Fix Lua library writeStructEnd() in TCompactProtocol

Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2297:
URL: https://github.com/apache/thrift/pull/2297


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2297: THRIFT-5325: Fix Lua library writeStructEnd() in TCompactProtocol

Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2297:
URL: https://github.com/apache/thrift/pull/2297#issuecomment-747803360


   Would be awesome to have some CV test that checks the issue so this doe not happen again. Is this feasible?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] elludraon commented on pull request #2297: THRIFT-5325: Fix Lua library writeStructEnd() in TCompactProtocol

Posted by GitBox <gi...@apache.org>.
elludraon commented on pull request #2297:
URL: https://github.com/apache/thrift/pull/2297#issuecomment-748302653


   I don't think I'll have time coming up, sorry!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G edited a comment on pull request #2297: THRIFT-5325: Fix Lua library writeStructEnd() in TCompactProtocol

Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2297:
URL: https://github.com/apache/thrift/pull/2297#issuecomment-747803360


   Would be awesome to have some CI test that checks the issue so this doe not happen again. Is this feasible?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org