You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/13 15:30:47 UTC

[GitHub] [kafka] mimaison opened a new pull request #11212: KAFKA-13200: Fix MirrorMaker2 connector version

mimaison opened a new pull request #11212:
URL: https://github.com/apache/kafka/pull/11212


   Use the Kafka version instead of hardcoding it to 1.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mimaison commented on pull request #11212: KAFKA-13200: Fix MirrorMaker2 connector version

Posted by GitBox <gi...@apache.org>.
mimaison commented on pull request #11212:
URL: https://github.com/apache/kafka/pull/11212#issuecomment-962970196


   > Cool. So... the version info in the headers will be changed from 1 to 3.1.0, 3.1.0, ... etc. Do I understand correctly?
   
   Yes, with this change, this will report the Kafka version, for example 3.1.0 instead of 1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mimaison commented on pull request #11212: KAFKA-13200: Fix MirrorMaker2 connector version

Posted by GitBox <gi...@apache.org>.
mimaison commented on pull request #11212:
URL: https://github.com/apache/kafka/pull/11212#issuecomment-898708844


   This should not have an impact. As far as I can tell the version is only externally visible when querying `/connector-plugins`.
   
   When we have a bunch of Connect clusters with different versions, it's nice to know immediately what's running. I also helps identifying the version of the runtime (as in most cases it's the same as the connectors). The FileStream connectors expose the real version too but they are often removed for security reasons.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dongjinleekr commented on pull request #11212: KAFKA-13200: Fix MirrorMaker2 connector version

Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #11212:
URL: https://github.com/apache/kafka/pull/11212#issuecomment-962623672


   Cool. So... the version info in the headers will be changed from 1 to 3.1.0, 3.1.0, ... etc. Do I understand correctly?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mimaison merged pull request #11212: KAFKA-13200: Fix MirrorMaker2 connector version

Posted by GitBox <gi...@apache.org>.
mimaison merged pull request #11212:
URL: https://github.com/apache/kafka/pull/11212


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ryannedolan commented on pull request #11212: KAFKA-13200: Fix MirrorMaker2 connector version

Posted by GitBox <gi...@apache.org>.
ryannedolan commented on pull request #11212:
URL: https://github.com/apache/kafka/pull/11212#issuecomment-898647966


   Does this have any impact on users as they upgrade? So far the MM connectors are mostly agnostic to what version of Kafka they interact with, and I'm wondering if syncing the versions like this would imply otherwise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mimaison commented on pull request #11212: KAFKA-13200: Fix MirrorMaker2 connector version

Posted by GitBox <gi...@apache.org>.
mimaison commented on pull request #11212:
URL: https://github.com/apache/kafka/pull/11212#issuecomment-899357757


   @showuon Good point, updated!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org